Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Unified Diff: third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h

Issue 2639153004: Worker: Stop accessing ExecutionContext passed by ExecutionContextTask (Closed)
Patch Set: address review comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h
diff --git a/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h b/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h
index 5bb45db376a6ee617da6c3ec02e0a8ee28f2a168..e6cfe66d1abeb21740427c477b5221ec439a2383 100644
--- a/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h
+++ b/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h
@@ -48,6 +48,7 @@ class ParentFrameTaskRunners;
class ThreadedMessagingProxyBase;
class WorkerGlobalScope;
class WorkerOrWorkletGlobalScope;
+class WorkerThread;
// A proxy to talk to the parent worker object. See class comments on
// ThreadedObjectProxyBase.h for lifetime of this class etc.
@@ -66,8 +67,11 @@ class CORE_EXPORT InProcessWorkerObjectProxy : public ThreadedObjectProxyBase {
void postMessageToWorkerObject(PassRefPtr<SerializedScriptValue>,
std::unique_ptr<MessagePortChannelArray>);
- void confirmMessageFromWorkerObject();
- void startPendingActivityTimer();
+ void processUnhandledException(int exceptionId, WorkerThread*);
+ void processMessageFromWorkerObject(
+ PassRefPtr<SerializedScriptValue> message,
+ std::unique_ptr<MessagePortChannelArray> channels,
+ WorkerThread*);
// ThreadedMessagingProxyBase overrides.
void reportException(const String& errorMessage,
@@ -86,6 +90,7 @@ class CORE_EXPORT InProcessWorkerObjectProxy : public ThreadedObjectProxyBase {
private:
friend class InProcessWorkerMessagingProxyForTest;
+ void startPendingActivityTimer();
void checkPendingActivity(TimerBase*);
// No guarantees about the lifetimes of tasks posted by this proxy wrt the

Powered by Google App Engine
This is Rietveld 408576698