Move property tree debugging code to platform/graphics/paint/.

Move property tree debugging code to platform/graphics/paint/.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2638763003
Cr-Commit-Position: refs/heads/master@{#444190}
Committed: https://chromium.googlesource.com/chromium/src/+/0221e755063d12ff67e52e5e5adce946ce06d3c0

[chrishtr, 2017-01-17 00:07:35]

Description was changed from

==========
none


none


none


none


none


Merge branch 'master' into debug


Merge branch 'master' into debug


none

BUG=
==========

to

==========
none


none


none


none


none


Merge branch 'master' into debug


Merge branch 'master' into debug


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-01-17 00:08:03]

Description was changed from

==========
none


none


none


none


none


Merge branch 'master' into debug


Merge branch 'master' into debug


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Move property tree debugging code to platform/graphics/paint/.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-01-17 00:11:25]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 00:11:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 00:28:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 00:28:07]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[chrishtr, 2017-01-17 02:50:45]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 02:50:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 03:06:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 03:07:01]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chrishtr, 2017-01-17 03:57:33]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 03:57:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 05:19:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 05:19:49]

Dry run: This issue passed the CQ dry run.

[chrishtr, 2017-01-17 15:51:20]

chrishtr@chromium.org changed reviewers:
+ wkorman@chromium.org

[wkorman, 2017-01-17 19:19:58]

lgtm

https://codereview.chromium.org/2638763003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.h (left):

https://codereview.chromium.org/2638763003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.h:38: CORE_EXPORT
void showPaintPropertyPath(
Just curious, what was catalyst for moving to platform/ -- desire to be able to
print from cc code, or it just seemed the more appropriate place?

https://codereview.chromium.org/2638763003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.cpp
(right):

https://codereview.chromium.org/2638763003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.cpp:79:
return transform()->treeAsString() + "\n" + clip()->treeAsString() + "\n" +
nit: StringBuilder here also could be worthwhile, the four strings could be
large, not like performance is a big thing here though, fine either way.

https://codereview.chromium.org/2638763003/diff/100001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/platform/graphics/paint/ScrollPaintPropertyNode.cpp
(right):

https://codereview.chromium.org/2638763003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/graphics/paint/ScrollPaintPropertyNode.cpp:38:
String ScrollPaintPropertyNode::treeAsString() const {
nit: toTreeString() and toPathString() seem more in line with naming patterns
but I don't feel strongly. Here's a Perl one-liner if it makes a difference:

% find ./platform/graphics/paint -type f | xargs perl -p -i -e
's/treeAsString/toTreeString/g'

:)

https://codereview.chromium.org/2638763003/diff/100001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.cpp
(right):

https://codereview.chromium.org/2638763003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.cpp:34:
return blink::PropertyTreeStatePrinter<blink::TransformPaintPropertyNode>()
Do we still need the blink:: prefix on these? Same rest of change.

[chrishtr, 2017-01-17 22:06:45]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-01-17 22:06:46]

https://codereview.chromium.org/2638763003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.h (left):

https://codereview.chromium.org/2638763003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.h:38: CORE_EXPORT
void showPaintPropertyPath(
On 2017/01/17 at 19:19:58, wkorman wrote:
> Just curious, what was catalyst for moving to platform/ -- desire to be able
to print from cc code, or it just seemed the more appropriate place?

It was:

1. to be able to print from platform code, since platform code can't call into
core/. Especially unittests, which can't even link against core

2. make it easier to debug stuff, since you just say
propertyTreeState.treeAsString() etc.

https://codereview.chromium.org/2638763003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.cpp
(right):

https://codereview.chromium.org/2638763003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.cpp:79:
return transform()->treeAsString() + "\n" + clip()->treeAsString() + "\n" +
On 2017/01/17 at 19:19:58, wkorman wrote:
> nit: StringBuilder here also could be worthwhile, the four strings could be
large, not like performance is a big thing here though, fine either way.

Prefer to just leave it because it's debugging output.

https://codereview.chromium.org/2638763003/diff/100001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/platform/graphics/paint/ScrollPaintPropertyNode.cpp
(right):

https://codereview.chromium.org/2638763003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/graphics/paint/ScrollPaintPropertyNode.cpp:38:
String ScrollPaintPropertyNode::treeAsString() const {
On 2017/01/17 at 19:19:58, wkorman wrote:
> nit: toTreeString() and toPathString() seem more in line with naming patterns
but I don't feel strongly. Here's a Perl one-liner if it makes a difference:
> 
> % find ./platform/graphics/paint -type f | xargs perl -p -i -e
's/treeAsString/toTreeString/g'
> 
> :)

Done. Script worked well!

[chrishtr, 2017-01-17 22:06:46]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2638763003/#ps140001
(title: "none")

[commit-bot: I haz the power, 2017-01-17 22:07:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 23:44:40]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1484690805126930,
"parent_rev": "3bbab9e965274605d4b83f7c5590d8806c6db835", "commit_rev":
"0221e755063d12ff67e52e5e5adce946ce06d3c0"}

[commit-bot: I haz the power, 2017-01-17 23:45:13]

Description was changed from

==========
Move property tree debugging code to platform/graphics/paint/.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Move property tree debugging code to platform/graphics/paint/.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2638763003
Cr-Commit-Position: refs/heads/master@{#444190}
Committed:
https://chromium.googlesource.com/chromium/src/+/0221e755063d12ff67e52e5e5adc...
==========

[commit-bot: I haz the power, 2017-01-17 23:45:14]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/0221e755063d12ff67e52e5e5adc...

[pdr., 2017-01-18 06:02:26]

On 2017/01/17 at 23:45:14, commit-bot wrote:
> Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/0221e755063d12ff67e52e5e5adc...

This is causing failures on the bots:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win%...

e.g., All/PaintPropertyTreePrinterTest.SimpleClipTreePath/0:
../../third_party/WebKit/Source/core/paint/PaintPropertyTreePrinterTest.cpp:107:
Failure
Value of: clipPathAsString.ascii().data()
Expected: matches regular expression "root .* rect.*  .* rect.*    .* rect.*"
  Actual: 0x1b5e89465470 pointing to " 0x1c0e23ed4710 parent=0x0
localTransformSpace=0x1c0e23ec4100 rect=-1.67772e+07,-1.67772e+07
3.35544e+07x3.35544e+07 radii:(tl:0x0; tr:0x0; bl:0x0; br:0x0)
directCompositingReasons=none?   0x1c0e23ed4790 parent=0x1c0e23ed4710
localTransformSpace=0x1c0e23ec41f0 rect=0,0 800x600 radii:(tl:0x0; tr:0x0;
bl:0x0; br:0x0) directCompositingReasons=none?     0x1c0e23ed4810
parent=0x1c0e23ed4790 localTransformSpace=0x1c0e23ec41f0 rect=48,18 40x60
radii:(tl:0x0; tr:0x0; bl:0x0; br:0x0) directCompositingReasons=none?"

[meade_UTC10, 2017-01-18 06:03:59]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/2639143002/ by meade@chromium.org.

The reason for reverting is: Caused failures on 4 waterfall bots:

WebKit Linux Trusty (dbg):
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty...

WebKit Mac10.11 (dbg)
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28...

WebKit Win x64 Builder (dbg)
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Bu...

WebKit Win7 (dbg)
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%...

BUG=682113.