NotificationController handles an ownership of NotificaitonClient

NotificationController handles an ownership of NotificaitonClient

NotificationClient is only used by NotificationController. So, NotificationController is able to have ownership of the client by using OwnPtr. The client's life cycle is more clear via clear ownership definition.

BUG=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173468

[jochen (gone - plz use gerrit), 2014-05-05 07:35:14]

https://codereview.chromium.org/263883004/diff/20001/Source/web/WebLocalFrame...
File Source/web/WebLocalFrameImpl.h (right):

https://codereview.chromium.org/263883004/diff/20001/Source/web/WebLocalFrame...
Source/web/WebLocalFrameImpl.h:375: OwnPtr<NotificationPresenterImpl>
m_notificationPresenter;
why do you need this member now?

[gyuyoung-inactive, 2014-05-06 15:26:08]

https://codereview.chromium.org/263883004/diff/20001/Source/web/WebLocalFrame...
File Source/web/WebLocalFrameImpl.h (right):

https://codereview.chromium.org/263883004/diff/20001/Source/web/WebLocalFrame...
Source/web/WebLocalFrameImpl.h:375: OwnPtr<NotificationPresenterImpl>
m_notificationPresenter;
On 2014/05/05 07:35:14, jochen wrote:
> why do you need this member now?

Yes, we don't need to keep this member and notificationPresenterImpl() indeed.
Moved those inside setWebCoreFrame() function and removed from header file.

[jochen (gone - plz use gerrit), 2014-05-06 15:56:34]

lgtm

[gyuyoung-inactive, 2014-05-06 21:18:31]

The CQ bit was checked by gyuyoung.kim@samsung.com

[commit-bot: I haz the power, 2014-05-06 21:19:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/263883004/40001

[commit-bot: I haz the power, 2014-05-06 21:41:14]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_blink_dbg on tryserver.blink
  linux_blink_rel on tryserver.blink
  mac_blink_rel on tryserver.blink
  win_blink_rel on tryserver.blink

[commit-bot: I haz the power, 2014-05-06 21:58:00]

FYI, CQ is re-trying this CL (attempt #2).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_blink_dbg on tryserver.blink
  linux_blink_rel on tryserver.blink
  mac_blink_rel on tryserver.blink
  win_blink_rel on tryserver.blink

[commit-bot: I haz the power, 2014-05-06 22:08:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-06 22:08:10]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink

[gyuyoung-inactive, 2014-05-07 02:23:23]

The CQ bit was checked by gyuyoung.kim@samsung.com

[gyuyoung-inactive, 2014-05-07 02:23:53]

The CQ bit was unchecked by gyuyoung.kim@samsung.com

[commit-bot: I haz the power, 2014-05-07 02:24:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/263883004/60001

[gyuyoung-inactive, 2014-05-07 03:05:46]

The CQ bit was checked by gyuyoung.kim@samsung.com

[commit-bot: I haz the power, 2014-05-07 03:06:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/263883004/60001

[commit-bot: I haz the power, 2014-05-07 04:32:54]

Change committed as 173468