Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Side by Side Diff: Source/web/WebLocalFrameImpl.h

Issue 263883004: NotificationController handles an ownership of NotificaitonClient (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 317 matching lines...) Expand 10 before | Expand all | Expand 10 after
328 void setWebCoreFrame(PassRefPtr<WebCore::LocalFrame>); 328 void setWebCoreFrame(PassRefPtr<WebCore::LocalFrame>);
329 329
330 void loadJavaScriptURL(const WebCore::KURL&); 330 void loadJavaScriptURL(const WebCore::KURL&);
331 331
332 // Returns a hit-tested VisiblePosition for the given point 332 // Returns a hit-tested VisiblePosition for the given point
333 WebCore::VisiblePosition visiblePositionForWindowPoint(const WebPoint&); 333 WebCore::VisiblePosition visiblePositionForWindowPoint(const WebPoint&);
334 334
335 WebPlugin* focusedPluginIfInputMethodSupported(); 335 WebPlugin* focusedPluginIfInputMethodSupported();
336 336
337 // Returns the provider of desktop notifications. 337 // Returns the provider of desktop notifications.
338 NotificationPresenterImpl* notificationPresenterImpl(); 338 PassOwnPtr<NotificationPresenterImpl> notificationPresenterImpl();
339 339
340 FrameLoaderClientImpl m_frameLoaderClientImpl; 340 FrameLoaderClientImpl m_frameLoaderClientImpl;
341 341
342 // The embedder retains a reference to the WebCore LocalFrame while it is ac tive in the DOM. This 342 // The embedder retains a reference to the WebCore LocalFrame while it is ac tive in the DOM. This
343 // reference is released when the frame is removed from the DOM or the entir e page is closed. 343 // reference is released when the frame is removed from the DOM or the entir e page is closed.
344 // FIXME: These will need to change to WebFrame when we introduce WebFramePr oxy. 344 // FIXME: These will need to change to WebFrame when we introduce WebFramePr oxy.
345 RefPtr<WebCore::LocalFrame> m_frame; 345 RefPtr<WebCore::LocalFrame> m_frame;
346 WebLocalFrameImpl* m_parent; 346 WebLocalFrameImpl* m_parent;
347 WebLocalFrameImpl* m_previousSibling; 347 WebLocalFrameImpl* m_previousSibling;
348 WebLocalFrameImpl* m_nextSibling; 348 WebLocalFrameImpl* m_nextSibling;
(...skipping 16 matching lines...) Expand all
365 365
366 // Valid between calls to BeginPrint() and EndPrint(). Containts the print 366 // Valid between calls to BeginPrint() and EndPrint(). Containts the print
367 // information. Is used by PrintPage(). 367 // information. Is used by PrintPage().
368 OwnPtr<ChromePrintContext> m_printContext; 368 OwnPtr<ChromePrintContext> m_printContext;
369 369
370 // Stores the additional input events offset and scale when device metrics e mulation is enabled. 370 // Stores the additional input events offset and scale when device metrics e mulation is enabled.
371 WebCore::IntSize m_inputEventsOffsetForEmulation; 371 WebCore::IntSize m_inputEventsOffsetForEmulation;
372 float m_inputEventsScaleFactorForEmulation; 372 float m_inputEventsScaleFactorForEmulation;
373 373
374 // The provider of desktop notifications; 374 // The provider of desktop notifications;
375 NotificationPresenterImpl m_notificationPresenter; 375 OwnPtr<NotificationPresenterImpl> m_notificationPresenter;
jochen (gone - plz use gerrit) 2014/05/05 07:35:14 why do you need this member now?
gyuyoung-inactive 2014/05/06 15:26:09 Yes, we don't need to keep this member and notific
376 376
377 UserMediaClientImpl m_userMediaClientImpl; 377 UserMediaClientImpl m_userMediaClientImpl;
378 }; 378 };
379 379
380 DEFINE_TYPE_CASTS(WebLocalFrameImpl, WebFrame, frame, frame->isWebLocalFrame(), frame.isWebLocalFrame()); 380 DEFINE_TYPE_CASTS(WebLocalFrameImpl, WebFrame, frame, frame->isWebLocalFrame(), frame.isWebLocalFrame());
381 381
382 } // namespace blink 382 } // namespace blink
383 383
384 #endif 384 #endif
OLDNEW
« no previous file with comments | « Source/modules/notifications/NotificationController.cpp ('k') | Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698