Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1594)

Unified Diff: Source/modules/notifications/NotificationController.h

Issue 263883004: NotificationController handles an ownership of NotificaitonClient (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/notifications/NotificationController.h
diff --git a/Source/modules/notifications/NotificationController.h b/Source/modules/notifications/NotificationController.h
index 6022bca0a0701ce88817f3da9878c4c3b0e327d6..da353f6308c09ba90d07a2d22cc362834e4e1445 100644
--- a/Source/modules/notifications/NotificationController.h
+++ b/Source/modules/notifications/NotificationController.h
@@ -39,22 +39,22 @@ class NotificationController FINAL : public Supplement<LocalFrame> {
public:
virtual ~NotificationController();
- static PassOwnPtr<NotificationController> create(NotificationClient*);
+ static PassOwnPtr<NotificationController> create(PassOwnPtr<NotificationClient>);
static const char* supplementName();
static NotificationController* from(LocalFrame* frame) { return static_cast<NotificationController*>(Supplement<LocalFrame>::from(frame, supplementName())); }
static NotificationClient* clientFrom(LocalFrame*);
- NotificationClient* client() { return m_client; }
+ NotificationClient* client() { return m_client.get(); }
virtual void trace(Visitor*) OVERRIDE { }
private:
- explicit NotificationController(NotificationClient*);
+ explicit NotificationController(PassOwnPtr<NotificationClient>);
- NotificationClient* m_client;
+ OwnPtr<NotificationClient> m_client;
};
-void provideNotification(LocalFrame&, NotificationClient*);
+void provideNotification(LocalFrame&, PassOwnPtr<NotificationClient>);
} // namespace WebCore
« no previous file with comments | « Source/modules/notifications/NotificationClient.h ('k') | Source/modules/notifications/NotificationController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698