Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1325)

Unified Diff: Source/modules/notifications/NotificationController.cpp

Issue 263883004: NotificationController handles an ownership of NotificaitonClient (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/notifications/NotificationController.h ('k') | Source/web/WebLocalFrameImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/notifications/NotificationController.cpp
diff --git a/Source/modules/notifications/NotificationController.cpp b/Source/modules/notifications/NotificationController.cpp
index 3c50e0f3987ff0766cabc7dfba118c2873148397..47abc467407a14ebba2d83382611c3825a46e899 100644
--- a/Source/modules/notifications/NotificationController.cpp
+++ b/Source/modules/notifications/NotificationController.cpp
@@ -31,7 +31,7 @@
namespace WebCore {
-NotificationController::NotificationController(NotificationClient* client)
+NotificationController::NotificationController(PassOwnPtr<NotificationClient> client)
: m_client(client)
{
}
@@ -40,7 +40,7 @@ NotificationController::~NotificationController()
{
}
-PassOwnPtr<NotificationController> NotificationController::create(NotificationClient* client)
+PassOwnPtr<NotificationController> NotificationController::create(PassOwnPtr<NotificationClient> client)
{
return adoptPtr(new NotificationController(client));
}
@@ -57,7 +57,7 @@ const char* NotificationController::supplementName()
return "NotificationController";
}
-void provideNotification(LocalFrame& frame, NotificationClient* client)
+void provideNotification(LocalFrame& frame, PassOwnPtr<NotificationClient> client)
{
NotificationController::provideTo(frame, NotificationController::supplementName(), NotificationController::create(client));
}
« no previous file with comments | « Source/modules/notifications/NotificationController.h ('k') | Source/web/WebLocalFrameImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698