Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1304)

Unified Diff: components/browser_sync/profile_sync_components_factory_impl.cc

Issue 2638573002: Add result to DumpWithoutCrashing, to indicate whether it did anything. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/debug/dump_without_crashing.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/browser_sync/profile_sync_components_factory_impl.cc
diff --git a/components/browser_sync/profile_sync_components_factory_impl.cc b/components/browser_sync/profile_sync_components_factory_impl.cc
index 93d83a7411f33888a4aef057959d26b80d3c17fc..806d21ce4aecb29711621dfffd00f0d8008aa16c 100644
--- a/components/browser_sync/profile_sync_components_factory_impl.cc
+++ b/components/browser_sync/profile_sync_components_factory_impl.cc
@@ -143,7 +143,8 @@ void ProfileSyncComponentsFactoryImpl::RegisterCommonDataTypes(
// get USS as stable as possible.
sync_service->RegisterDataTypeController(
base::MakeUnique<ModelTypeController>(
- syncer::DEVICE_INFO, base::Bind(&base::debug::DumpWithoutCrashing),
+ syncer::DEVICE_INFO,
+ base::Bind(base::IgnoreResult(&base::debug::DumpWithoutCrashing)),
sync_client_, ui_thread_));
} else {
sync_service->RegisterDataTypeController(
@@ -158,7 +159,8 @@ void ProfileSyncComponentsFactoryImpl::RegisterCommonDataTypes(
if (base::FeatureList::IsEnabled(switches::kSyncUSSAutocomplete)) {
sync_service->RegisterDataTypeController(
base::MakeUnique<ModelTypeController>(
- syncer::AUTOFILL, base::Bind(&base::debug::DumpWithoutCrashing),
+ syncer::AUTOFILL,
+ base::Bind(base::IgnoreResult(&base::debug::DumpWithoutCrashing)),
sync_client_, db_thread_));
} else {
sync_service->RegisterDataTypeController(
« no previous file with comments | « base/debug/dump_without_crashing.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698