Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2638513002: Enable --harmony-trailing-commas (Closed)

Created:
3 years, 11 months ago by jwolfe
Modified:
3 years, 10 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Enable --harmony-trailing-commas Also updated some tests due to the change. The general pattern is when a trailing comma is expected to cause a SyntaxError, an additional comma was added. BUG=v8:5051 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2638513002 Cr-Commit-Position: refs/heads/master@{#42826} Committed: https://chromium.googlesource.com/v8/v8/+/ea96fdec68d5c536f2e9d2deb3bbe02811210bd1

Patch Set 1 #

Total comments: 1

Patch Set 2 : put the flag back in, but enable it by default #

Patch Set 3 : revert test-parsing.cc to fix preparser test failures #

Patch Set 4 : rebase #

Total comments: 1

Patch Set 5 : put the harmony flag back into the harmony test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -39 lines) Patch
M src/flag-definitions.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M test/message/formal-parameters-trailing-comma.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/formal-parameters-trailing-comma.out View 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/extra-commas.js View 1 chunk +4 lines, -4 lines 0 comments Download
M test/mjsunit/regress/regress-2470.js View 1 chunk +4 lines, -2 lines 0 comments Download
M test/test262/test262.status View 1 2 3 1 chunk +0 lines, -22 lines 0 comments Download
M test/webkit/fast/js/parser-syntax-check-expected.txt View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
jwolfe
PTAL. This is my first attempt at a patch like this, so I expect lots ...
3 years, 11 months ago (2017-01-14 00:39:51 UTC) #3
adamk
https://codereview.chromium.org/2638513002/diff/1/src/flag-definitions.h File src/flag-definitions.h (left): https://codereview.chromium.org/2638513002/diff/1/src/flag-definitions.h#oldcode213 src/flag-definitions.h:213: V(harmony_trailing_commas, \ Rather than removing this, you should move ...
3 years, 11 months ago (2017-01-14 00:57:13 UTC) #4
jwolfe
PTAL. the bot_default and test262 tests are passing.
3 years, 10 months ago (2017-01-30 21:50:17 UTC) #5
adamk
lgtm % one comment https://codereview.chromium.org/2638513002/diff/60001/test/mjsunit/harmony/trailing-commas-length.js File test/mjsunit/harmony/trailing-commas-length.js (left): https://codereview.chromium.org/2638513002/diff/60001/test/mjsunit/harmony/trailing-commas-length.js#oldcode5 test/mjsunit/harmony/trailing-commas-length.js:5: // Flags: --harmony-trailing-commas You can ...
3 years, 10 months ago (2017-01-30 22:41:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2638513002/80001
3 years, 10 months ago (2017-01-31 22:34:16 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 23:31:04 UTC) #17
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/ea96fdec68d5c536f2e9d2deb3bbe028112...

Powered by Google App Engine
This is Rietveld 408576698