Enable --harmony-trailing-commas

Enable --harmony-trailing-commas

Also updated some tests due to the change. The general pattern is when a
trailing comma is expected to cause a SyntaxError, an additional comma was
added.

BUG=v8:5051
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2638513002
Cr-Commit-Position: refs/heads/master@{#42826}
Committed: https://chromium.googlesource.com/v8/v8/+/ea96fdec68d5c536f2e9d2deb3bbe02811210bd1

[jwolfe, 2017-01-14 00:38:47]

Description was changed from

==========
Enable --harmony-trailing-commas and remove the flag

Also updated some tests due to the change. The general pattern is when a
trailing comma is expected to cause a SyntaxError, I added an additional
comma.

BUG=v8:5051
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Enable --harmony-trailing-commas and remove the flag

Also updated some tests due to the change. The general pattern is when a
trailing comma is expected to cause a SyntaxError, I added an additional
comma.

BUG=v8:5051
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[jwolfe, 2017-01-14 00:38:47]

jwolfe@igalia.com changed reviewers:
+ adamk@chromium.org

[jwolfe, 2017-01-14 00:39:51]

PTAL.

This is my first attempt at a patch like this, so I expect lots of changes will
be needed.

Please especially advise on what to do about the test changes. Some of it seems
kinda silly.

[adamk, 2017-01-14 00:57:13]

https://codereview.chromium.org/2638513002/diff/1/src/flag-definitions.h
File src/flag-definitions.h (left):

https://codereview.chromium.org/2638513002/diff/1/src/flag-definitions.h#oldc...
src/flag-definitions.h:213: V(harmony_trailing_commas,                          
     \
Rather than removing this, you should move it down to HARMONY_SHIPPING_BASE
below. This would have been clearer except that I deleted our last shipping flag
(--harmony-async-await) earlier this week.

The idea is that a flag moves from INPROGRESS -> STAGED -> SHIPPING, and then
once it's shipped in a stable Chrome it gets removed.

Once you're not deleting the flag, most of the changes in this CL go away.

[jwolfe, 2017-01-30 21:50:17]

PTAL. the bot_default and test262 tests are passing.

[adamk, 2017-01-30 22:41:03]

lgtm % one comment

https://codereview.chromium.org/2638513002/diff/60001/test/mjsunit/harmony/tr...
File test/mjsunit/harmony/trailing-commas-length.js (left):

https://codereview.chromium.org/2638513002/diff/60001/test/mjsunit/harmony/tr...
test/mjsunit/harmony/trailing-commas-length.js:5: // Flags:
--harmony-trailing-commas
You can leave this flag here until it's actually removed from flag-definitions.h

[jwolfe, 2017-01-31 19:53:11]

Description was changed from

==========
Enable --harmony-trailing-commas and remove the flag

Also updated some tests due to the change. The general pattern is when a
trailing comma is expected to cause a SyntaxError, I added an additional
comma.

BUG=v8:5051
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Enable --harmony-trailing-commas

Also updated some tests due to the change. The general pattern is when a
trailing comma is expected to cause a SyntaxError, an additional comma was
added.

BUG=v8:5051
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[jwolfe, 2017-01-31 19:56:45]

The CQ bit was checked by jwolfe@igalia.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 19:56:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 19:58:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 19:58:40]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/20287)
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[jwolfe, 2017-01-31 22:34:05]

The CQ bit was checked by jwolfe@igalia.com

[jwolfe, 2017-01-31 22:34:05]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2638513002/#ps80001
(title: "put the harmony flag back into the harmony test")

[commit-bot: I haz the power, 2017-01-31 22:34:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 23:30:57]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1485902045540480,
"parent_rev": "639bf4aa9cb6fe478a7a46e402344319c50e211a", "commit_rev":
"ea96fdec68d5c536f2e9d2deb3bbe02811210bd1"}

[commit-bot: I haz the power, 2017-01-31 23:31:03]

Description was changed from

==========
Enable --harmony-trailing-commas

Also updated some tests due to the change. The general pattern is when a
trailing comma is expected to cause a SyntaxError, an additional comma was
added.

BUG=v8:5051
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Enable --harmony-trailing-commas

Also updated some tests due to the change. The general pattern is when a
trailing comma is expected to cause a SyntaxError, an additional comma was
added.

BUG=v8:5051
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2638513002
Cr-Commit-Position: refs/heads/master@{#42826}
Committed:
https://chromium.googlesource.com/v8/v8/+/ea96fdec68d5c536f2e9d2deb3bbe028112...
==========

[commit-bot: I haz the power, 2017-01-31 23:31:04]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/ea96fdec68d5c536f2e9d2deb3bbe028112...