Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2636243003: Consolidate PhysicalWeb list launch code (Closed)

Created:
3 years, 11 months ago by cco3
Modified:
3 years, 11 months ago
Reviewers:
Ted C, mattreynolds
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Consolidate PhysicalWeb list launch code Currently, only the Intent creation code is consolidated to launch an activity to list Physical Web URLs. This change also consolidates the actual call to launch the trusted intent. BUG=663842 Review-Url: https://codereview.chromium.org/2636243003 Cr-Commit-Position: refs/heads/master@{#444157} Committed: https://chromium.googlesource.com/chromium/src/+/0df20a42550425c0edc2ca31e76ea5fe1efff67c

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java View 2 chunks +1 line, -3 lines 1 comment Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
cco3
3 years, 11 months ago (2017-01-17 20:16:24 UTC) #2
cco3
Hi Ted, this is a follow up to https://codereview.chromium.org/2601273003
3 years, 11 months ago (2017-01-17 20:16:47 UTC) #4
mattreynolds
https://codereview.chromium.org/2636243003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java (left): https://codereview.chromium.org/2636243003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java#oldcode66 chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java:66: PhysicalWebUma.onActivityReferral(ListUrlsActivity.DIAGNOSTICS_REFERER); What do you think about passing the referer ...
3 years, 11 months ago (2017-01-17 20:28:15 UTC) #5
cco3
I considered it, but I don't know if we should mandate a new referer be ...
3 years, 11 months ago (2017-01-17 20:46:42 UTC) #6
Ted C
lgtm
3 years, 11 months ago (2017-01-17 21:02:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2636243003/1
3 years, 11 months ago (2017-01-17 21:15:44 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 21:55:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0df20a42550425c0edc2ca31e76e...

Powered by Google App Engine
This is Rietveld 408576698