chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java - Issue 2636243003: Consolidate PhysicalWeb list launch code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java

Issue 2636243003: Consolidate PhysicalWeb list launch code (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java

index 5da90fcd773595b342116c2ce05ba4b74bd3c617..19771cea6a4ff508cb85dbd1876288b00d03d700 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java

@@ -17,7 +17,6 @@ import android.widget.TextView;

import org.chromium.base.ApiCompatibilityUtils;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.BasicNativePage;

-import org.chromium.chrome.browser.IntentHandler;

import org.chromium.chrome.browser.UrlConstants;

import org.chromium.chrome.browser.tab.Tab;

import org.chromium.components.location.LocationUtils;

@@ -64,8 +63,7 @@ public class PhysicalWebDiagnosticsPage extends BasicNativePage {

@Override

public void onClick(View v) {

PhysicalWebUma.onActivityReferral(ListUrlsActivity.DIAGNOSTICS_REFERER);

mattreynolds 2017/01/17 20:28:14 What do you think about passing the referer info t

- IntentHandler.startChromeLauncherActivityForTrustedIntent(

- PhysicalWeb.createListUrlsIntent());

+ PhysicalWeb.showUrlList();

}

});