Send users to Physical WebUI instead of Activity

Send users to Physical WebUI instead of Activity

We have written a Physical Web WebUI that we intend to be the de facto
view for browsing Physical Web URLs.  This change makes sure the user
goes there when they try to display URLs from:
* the diagnostics page and
* the settings fragment.

BUG=663842
Review-Url: https://codereview.chromium.org/2601273003
Cr-Commit-Position: refs/heads/master@{#443393}
Committed: https://chromium.googlesource.com/chromium/src/+/b5c9bcd8091d35691e61a939eb2aa8201baf57c8

[cco3, 2016-12-29 22:42:27]

cco3@chromium.org changed reviewers:
+ mattreynolds@chromium.org

[cco3, 2016-12-29 22:42:27]

Please note that this change is dependent on
https://codereview.chromium.org/2603043002/ (which must be merged first)

[mattreynolds, 2017-01-04 01:30:51]

lgtm

[cco3, 2017-01-05 23:55:09]

cco3@chromium.org changed reviewers:
+ tedchoc@chromium.org

[cco3, 2017-01-05 23:55:09]

Hi Ted, would you be able to review this change?  Thanks in advance!

[cco3, 2017-01-12 20:41:15]

Hi Ted, do you have time to review this change?  If not, is there someone else
you could suggest to review it?

[Ted C, 2017-01-12 21:00:06]

lgtm ... sorry about missing that!

https://codereview.chromium.org/2601273003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java
(right):

https://codereview.chromium.org/2601273003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java:107:
startActivity(PhysicalWeb.createListUrlsIntent());
I think you need to use startChromeLauncherActivityForTrustedIntent here as
well.

[cco3, 2017-01-12 21:26:47]

https://codereview.chromium.org/2601273003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java
(right):

https://codereview.chromium.org/2601273003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java:107:
startActivity(PhysicalWeb.createListUrlsIntent());
On 2017/01/12 21:00:05, Ted C wrote:
> I think you need to use startChromeLauncherActivityForTrustedIntent here as
> well.

Done.

[cco3, 2017-01-12 21:26:51]

The CQ bit was checked by cco3@chromium.org

[cco3, 2017-01-12 21:26:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2601273003/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-12 21:27:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 21:31:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 21:31:17]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[cco3, 2017-01-12 21:48:50]

The CQ bit was checked by cco3@chromium.org

[cco3, 2017-01-12 21:48:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2601273003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-12 21:49:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 22:53:47]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484257730706990,
"parent_rev": "aecd7af67f224d47c674ab9233fb55dc2dcb443a", "commit_rev":
"b5c9bcd8091d35691e61a939eb2aa8201baf57c8"}

[commit-bot: I haz the power, 2017-01-12 22:54:25]

Description was changed from

==========
Send users to Physical WebUI instead of Activity

We have written a Physical Web WebUI that we intend to be the de facto
view for browsing Physical Web URLs.  This change makes sure the user
goes there when they try to display URLs from:
* the diagnostics page and
* the settings fragment.

BUG=663842
==========

to

==========
Send users to Physical WebUI instead of Activity

We have written a Physical Web WebUI that we intend to be the de facto
view for browsing Physical Web URLs.  This change makes sure the user
goes there when they try to display URLs from:
* the diagnostics page and
* the settings fragment.

BUG=663842

Review-Url: https://codereview.chromium.org/2601273003
Cr-Commit-Position: refs/heads/master@{#443393}
Committed:
https://chromium.googlesource.com/chromium/src/+/b5c9bcd8091d35691e61a939eb2a...
==========

[commit-bot: I haz the power, 2017-01-12 22:54:26]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b5c9bcd8091d35691e61a939eb2a...