Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2601273003: Send users to Physical WebUI instead of Activity (Closed)

Created:
3 years, 11 months ago by cco3
Modified:
3 years, 11 months ago
Reviewers:
Ted C, mattreynolds
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Send users to Physical WebUI instead of Activity We have written a Physical Web WebUI that we intend to be the de facto view for browsing Physical Web URLs. This change makes sure the user goes there when they try to display URLs from: * the diagnostics page and * the settings fragment. BUG=663842 Review-Url: https://codereview.chromium.org/2601273003 Cr-Commit-Position: refs/heads/master@{#443393} Committed: https://chromium.googlesource.com/chromium/src/+/b5c9bcd8091d35691e61a939eb2aa8201baf57c8

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2

Patch Set 3 : Rebase #

Messages

Total messages: 19 (9 generated)
cco3
Please note that this change is dependent on https://codereview.chromium.org/2603043002/ (which must be merged first)
3 years, 11 months ago (2016-12-29 22:42:27 UTC) #2
mattreynolds
lgtm
3 years, 11 months ago (2017-01-04 01:30:51 UTC) #3
cco3
Hi Ted, would you be able to review this change? Thanks in advance!
3 years, 11 months ago (2017-01-05 23:55:09 UTC) #5
cco3
Hi Ted, do you have time to review this change? If not, is there someone ...
3 years, 11 months ago (2017-01-12 20:41:15 UTC) #6
Ted C
lgtm ... sorry about missing that! https://codereview.chromium.org/2601273003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java File chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java (right): https://codereview.chromium.org/2601273003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java#newcode107 chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java:107: startActivity(PhysicalWeb.createListUrlsIntent()); I think ...
3 years, 11 months ago (2017-01-12 21:00:06 UTC) #7
cco3
https://codereview.chromium.org/2601273003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java File chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java (right): https://codereview.chromium.org/2601273003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java#newcode107 chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java:107: startActivity(PhysicalWeb.createListUrlsIntent()); On 2017/01/12 21:00:05, Ted C wrote: > I ...
3 years, 11 months ago (2017-01-12 21:26:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601273003/20001
3 years, 11 months ago (2017-01-12 21:27:30 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/135035) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 11 months ago (2017-01-12 21:31:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2601273003/40001
3 years, 11 months ago (2017-01-12 21:49:22 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 22:54:26 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b5c9bcd8091d35691e61a939eb2a...

Powered by Google App Engine
This is Rietveld 408576698