Implements CSSPropertyAPI for the column-count property.

Implements CSSPropertyAPI for the column-count property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyColumnCount from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
column-count property is stored in a CSSPropertyDescriptor, and is
called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIColumnCount.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIColumnCount.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIColumnCount.cpp, which implements CSSPropertyAPI.h.

BUG=668012
Review-Url: https://codereview.chromium.org/2635983007
Cr-Commit-Position: refs/heads/master@{#447485}
Committed: https://chromium.googlesource.com/chromium/src/+/633e649172fbbad21a1492ad7a226f2c380b7d7a

[aazzam, 2017-01-18 02:38:14]

Description was changed from

==========
Implements CSSPropertyAPI for the column-count property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyColumnCount from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
column-count property is stored in a CSSPropertyDescriptor, and is
called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIColumnCount.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIColumnCount.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIColumncount.cpp, which implements CSSPropertyAPI.h.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the column-count property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyColumnCount from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
column-count property is stored in a CSSPropertyDescriptor, and is
called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIColumnCount.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIColumnCount.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIColumnCount.cpp, which implements CSSPropertyAPI.h.

BUG=668012
==========

[aazzam, 2017-01-18 02:45:47]

aazzam@google.com changed reviewers:
+ alancutter@chromium.org

[aazzam, 2017-01-18 02:45:47]

please take a look alan! :)

[alancutter (OOO until 2018), 2017-01-18 03:02:31]

lgtm

[aazzam, 2017-01-18 03:10:35]

aazzam@google.com changed reviewers:
+ sashab@chromium.org

[aazzam, 2017-01-18 03:10:35]

sasha, ptal :)

[sashab, 2017-01-18 04:14:02]

Haha I read this and was like "there's a CSSPropertyColumnUtils?? How cool is
that' and then saw your dependent patchset XD

Hmm... Why have you put consumeColumnWidth and consumeColumnCount in the utils
file? It seems only consumeColumnWidthOrCount is used elsewhere in
CSSPropertyParser.cpp. Am I missing something? :)

[sashab, 2017-01-20 02:15:31]

lgtm

[aazzam, 2017-01-20 02:44:31]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 02:44:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 02:47:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 02:47:02]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[aazzam, 2017-01-20 03:38:33]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 03:38:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 05:10:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 05:10:47]

Dry run: This issue passed the CQ dry run.

[aazzam, 2017-01-30 23:24:28]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 23:25:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 00:52:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 00:52:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[aazzam, 2017-01-31 02:06:54]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 02:07:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 03:36:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 03:36:25]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[aazzam, 2017-02-01 01:42:29]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 01:43:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 03:25:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 03:25:20]

Dry run: This issue passed the CQ dry run.

[aazzam, 2017-02-01 04:25:17]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 04:25:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 04:27:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 04:27:20]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[aazzam, 2017-02-01 05:56:26]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 05:56:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 08:51:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 08:51:31]

Dry run: This issue passed the CQ dry run.

[aazzam, 2017-02-01 10:55:48]

The CQ bit was checked by aazzam@google.com

[aazzam, 2017-02-01 10:55:49]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org,
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2635983007/#ps140001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-01 10:56:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 10:59:51]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1485946548845310,
"parent_rev": "05eb316801c899b16b7ed77b628d1e2a498e26e3", "commit_rev":
"633e649172fbbad21a1492ad7a226f2c380b7d7a"}

[commit-bot: I haz the power, 2017-02-01 11:00:29]

Description was changed from

==========
Implements CSSPropertyAPI for the column-count property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyColumnCount from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
column-count property is stored in a CSSPropertyDescriptor, and is
called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIColumnCount.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIColumnCount.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIColumnCount.cpp, which implements CSSPropertyAPI.h.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the column-count property.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyColumnCount from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
column-count property is stored in a CSSPropertyDescriptor, and is
called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIColumnCount.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIColumnCount.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIColumnCount.cpp, which implements CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2635983007
Cr-Commit-Position: refs/heads/master@{#447485}
Committed:
https://chromium.googlesource.com/chromium/src/+/633e649172fbbad21a1492ad7a22...
==========

[commit-bot: I haz the power, 2017-02-01 11:00:31]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/633e649172fbbad21a1492ad7a22...