Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2634313003: Implements CSSPropertyAPI for the column-width property. (Closed)

Created:
3 years, 11 months ago by aazzam
Modified:
3 years, 10 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implements CSSPropertyAPI for the column-width property. A part of Project Ribbon, separating the parsing logic for CSS properties from the parser into an API. This patch removes CSSPropertyColumnWidth from the switch statement in parseSingleValue, and calls the API instead. A function pointer to the parseSingleValue function from the API for the column-width property is stored in a CSSPropertyDescriptor, and is called from CSSPropertyParser. This patch: - Adds CSSPropertyAPIColumnWidth.cpp to the BUILD.gn file. - Adds api_class flag to CSSProperties.in, which indicates that CSSPropertyAPIColumnWidth.h is generated. - Moves the parsing logic for page from CSSPropertyParser.cpp to CSSPropertyAPIColumnWidth.cpp, which implements CSSPropertyAPI.h. BUG=668012 Review-Url: https://codereview.chromium.org/2634313003 Cr-Commit-Position: refs/heads/master@{#447487} Committed: https://chromium.googlesource.com/chromium/src/+/d00a76bf063fbbde05990038e4b3770482d41fb1

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : added api_methods flag #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M third_party/WebKit/Source/core/css/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIColumnWidth.cpp View 1 chunk +17 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 32 (26 generated)
aazzam
please take a look alan! :)
3 years, 11 months ago (2017-01-18 02:45:38 UTC) #2
alancutter (OOO until 2018)
lgtm
3 years, 11 months ago (2017-01-18 03:02:35 UTC) #3
aazzam
sasha, ptal :)
3 years, 11 months ago (2017-01-18 03:10:18 UTC) #5
sashab
lgtm
3 years, 11 months ago (2017-01-20 02:15:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634313003/100001
3 years, 10 months ago (2017-02-01 11:02:43 UTC) #29
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 11:07:28 UTC) #32
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/d00a76bf063fbbde05990038e4b3...

Powered by Google App Engine
This is Rietveld 408576698