Implements CSSPropertyAPI for the margin properties.

Implements CSSPropertyAPI for the margin properties.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyMargin{Top,Right,Bottom,Left},
CSSProperty{Top,Right,Bottom,Left}, and
CSSPropertyWebkitMargin[Top|Right|Bottom|Left] from the switch statement
in parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
margin properties is stored in a CSSPropertyDescriptor, and is
called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIMargin.cpp and CSSPropertyAPIWebkitMargin.cpp to
  the BUILD.gn file.
- Adds api_class=CSSPropertyAPIMargin and
  api_class=CSSPropertyAPIWebkitMargin flag in CSSProperties.in to each
  of the margin and -webkit-margin properties respectively, which
  indicates that CSSPropertyAPIMargin.h and CSSPropertyWebkitMargin.h
  are generated.
- Moves the parsing logic for radius from CSSPropertyParser.cpp
  to CSSPropertyAPI[Webkit]Margin.cpp, which implements CSSPropertyAPI.h.

BUG=668012
Review-Url: https://codereview.chromium.org/2648703002
Cr-Original-Commit-Position: refs/heads/master@{#447430}
Committed: https://chromium.googlesource.com/chromium/src/+/72f22e3a5858ab9593cea5703c840b8f3c60327c
Review-Url: https://codereview.chromium.org/2648703002
Cr-Commit-Position: refs/heads/master@{#447473}
Committed: https://chromium.googlesource.com/chromium/src/+/bd564cefdfd28db390dcde233aa9bb5b5943abea

[aazzam, 2017-01-20 02:06:16]

aazzam@google.com changed reviewers:
+ sashab@chromium.org

[aazzam, 2017-01-20 02:06:16]

ptal sasha :)

[sashab, 2017-01-20 02:22:58]

Haha oh man this is an old one! LGTM.

Replaec '}' with '|' in CL description :) Also the convention is {a,b,c}
notation which is taken from shell expansion syntax:
http://tldp.org/LDP/Bash-Beginners-Guide/html/sect_03_04.html

[aazzam, 2017-01-20 02:45:00]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 02:45:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 02:47:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 02:47:35]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[aazzam, 2017-01-30 23:01:02]

Description was changed from

==========
Implements CSSPropertyAPI for the margin properties.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyMargin[Top|Right}Bottom|Left],
CSSProperty[Top|Right|Bottom|Left], and
CSSPropertyWebkitMargin[Top|Right|Bottom|Left] from the switch statement
in parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
margin properties is stored in a CSSPropertyDescriptor, and is
called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIMargin.cpp and CSSPropertyAPIWebkitMargin.cpp to
  the BUILD.gn file.
- Adds api_class=CSSPropertyAPIMargin and
  api_class=CSSPropertyAPIWebkitMargin flag in CSSProperties.in to each
  of the margin and -webkit-margin properties respectively, which
  indicates that CSSPropertyAPIMargin.h and CSSPropertyWebkitMargin.h
  are generated.
- Moves the parsing logic for radius from CSSPropertyParser.cpp
  to CSSPropertyAPI[Webkit]Margin.cpp, which implements CSSPropertyAPI.h.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the margin properties.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyMargin{Top,Right,Bottom,Left},
CSSProperty{Top,Right,Bottom,Left}, and
CSSPropertyWebkitMargin[Top|Right|Bottom|Left] from the switch statement
in parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
margin properties is stored in a CSSPropertyDescriptor, and is
called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIMargin.cpp and CSSPropertyAPIWebkitMargin.cpp to
  the BUILD.gn file.
- Adds api_class=CSSPropertyAPIMargin and
  api_class=CSSPropertyAPIWebkitMargin flag in CSSProperties.in to each
  of the margin and -webkit-margin properties respectively, which
  indicates that CSSPropertyAPIMargin.h and CSSPropertyWebkitMargin.h
  are generated.
- Moves the parsing logic for radius from CSSPropertyParser.cpp
  to CSSPropertyAPI[Webkit]Margin.cpp, which implements CSSPropertyAPI.h.

BUG=668012
==========

[aazzam, 2017-01-30 23:06:55]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 23:07:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 00:47:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 00:48:00]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[aazzam, 2017-01-31 02:04:34]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 02:05:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 03:48:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 03:48:54]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[aazzam, 2017-01-31 05:37:40]

The CQ bit was checked by aazzam@google.com

[aazzam, 2017-01-31 05:37:41]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2648703002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-31 05:37:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 06:43:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 06:43:34]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[aazzam, 2017-01-31 21:48:01]

The CQ bit was checked by aazzam@google.com

[commit-bot: I haz the power, 2017-01-31 21:48:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 23:23:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 23:23:04]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[aazzam, 2017-02-01 00:50:28]

The CQ bit was checked by aazzam@google.com

[aazzam, 2017-02-01 00:50:29]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2648703002/#ps60001
(title: "Fixed bug")

[commit-bot: I haz the power, 2017-02-01 00:51:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 02:51:16]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485910228735590,
"parent_rev": "a023c75cbfdf289ca3104d272c16447dead2c1a5", "commit_rev":
"72f22e3a5858ab9593cea5703c840b8f3c60327c"}

[commit-bot: I haz the power, 2017-02-01 02:55:05]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485910228735590,
"parent_rev": "a023c75cbfdf289ca3104d272c16447dead2c1a5", "commit_rev":
"72f22e3a5858ab9593cea5703c840b8f3c60327c"}

[commit-bot: I haz the power, 2017-02-01 02:55:11]

Description was changed from

==========
Implements CSSPropertyAPI for the margin properties.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyMargin{Top,Right,Bottom,Left},
CSSProperty{Top,Right,Bottom,Left}, and
CSSPropertyWebkitMargin[Top|Right|Bottom|Left] from the switch statement
in parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
margin properties is stored in a CSSPropertyDescriptor, and is
called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIMargin.cpp and CSSPropertyAPIWebkitMargin.cpp to
  the BUILD.gn file.
- Adds api_class=CSSPropertyAPIMargin and
  api_class=CSSPropertyAPIWebkitMargin flag in CSSProperties.in to each
  of the margin and -webkit-margin properties respectively, which
  indicates that CSSPropertyAPIMargin.h and CSSPropertyWebkitMargin.h
  are generated.
- Moves the parsing logic for radius from CSSPropertyParser.cpp
  to CSSPropertyAPI[Webkit]Margin.cpp, which implements CSSPropertyAPI.h.

BUG=668012
==========

to

==========
Implements CSSPropertyAPI for the margin properties.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyMargin{Top,Right,Bottom,Left},
CSSProperty{Top,Right,Bottom,Left}, and
CSSPropertyWebkitMargin[Top|Right|Bottom|Left] from the switch statement
in parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
margin properties is stored in a CSSPropertyDescriptor, and is
called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIMargin.cpp and CSSPropertyAPIWebkitMargin.cpp to
  the BUILD.gn file.
- Adds api_class=CSSPropertyAPIMargin and
  api_class=CSSPropertyAPIWebkitMargin flag in CSSProperties.in to each
  of the margin and -webkit-margin properties respectively, which
  indicates that CSSPropertyAPIMargin.h and CSSPropertyWebkitMargin.h
  are generated.
- Moves the parsing logic for radius from CSSPropertyParser.cpp
  to CSSPropertyAPI[Webkit]Margin.cpp, which implements CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2648703002
Cr-Commit-Position: refs/heads/master@{#447430}
Committed:
https://chromium.googlesource.com/chromium/src/+/72f22e3a5858ab9593cea5703c84...
==========

[commit-bot: I haz the power, 2017-02-01 02:55:16]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/72f22e3a5858ab9593cea5703c84...

[aazzam, 2017-02-01 03:06:16]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2668753005/ by aazzam@google.com.

The reason for reverting is: conflict with patch landed at the same time.

[tsergeant, 2017-02-01 03:11:33]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2668143003/ by tsergeant@chromium.org.

The reason for reverting is: conflict with patch landed at the same time.

[findit-for-me, 2017-02-01 03:18:29]

FYI: Findit identified this CL at revision 447430 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[aazzam, 2017-02-01 04:16:38]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 04:16:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aazzam, 2017-02-01 04:23:43]

The CQ bit was checked by aazzam@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 04:23:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aazzam, 2017-02-01 05:56:11]

The CQ bit was unchecked by aazzam@google.com

[aazzam, 2017-02-01 05:56:14]

The CQ bit was checked by aazzam@google.com

[aazzam, 2017-02-01 05:56:15]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2648703002/#ps120001
(title: "removed accidental lines in json")

[commit-bot: I haz the power, 2017-02-01 05:56:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 08:22:31]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1485928574630230,
"parent_rev": "ab70c862d2b27087dd382a65a00001c666550cdd", "commit_rev":
"bd564cefdfd28db390dcde233aa9bb5b5943abea"}

[commit-bot: I haz the power, 2017-02-01 08:23:07]

Description was changed from

==========
Implements CSSPropertyAPI for the margin properties.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyMargin{Top,Right,Bottom,Left},
CSSProperty{Top,Right,Bottom,Left}, and
CSSPropertyWebkitMargin[Top|Right|Bottom|Left] from the switch statement
in parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
margin properties is stored in a CSSPropertyDescriptor, and is
called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIMargin.cpp and CSSPropertyAPIWebkitMargin.cpp to
  the BUILD.gn file.
- Adds api_class=CSSPropertyAPIMargin and
  api_class=CSSPropertyAPIWebkitMargin flag in CSSProperties.in to each
  of the margin and -webkit-margin properties respectively, which
  indicates that CSSPropertyAPIMargin.h and CSSPropertyWebkitMargin.h
  are generated.
- Moves the parsing logic for radius from CSSPropertyParser.cpp
  to CSSPropertyAPI[Webkit]Margin.cpp, which implements CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2648703002
Cr-Commit-Position: refs/heads/master@{#447430}
Committed:
https://chromium.googlesource.com/chromium/src/+/72f22e3a5858ab9593cea5703c84...
==========

to

==========
Implements CSSPropertyAPI for the margin properties.

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyMargin{Top,Right,Bottom,Left},
CSSProperty{Top,Right,Bottom,Left}, and
CSSPropertyWebkitMargin[Top|Right|Bottom|Left] from the switch statement
in parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
margin properties is stored in a CSSPropertyDescriptor, and is
called from CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIMargin.cpp and CSSPropertyAPIWebkitMargin.cpp to
  the BUILD.gn file.
- Adds api_class=CSSPropertyAPIMargin and
  api_class=CSSPropertyAPIWebkitMargin flag in CSSProperties.in to each
  of the margin and -webkit-margin properties respectively, which
  indicates that CSSPropertyAPIMargin.h and CSSPropertyWebkitMargin.h
  are generated.
- Moves the parsing logic for radius from CSSPropertyParser.cpp
  to CSSPropertyAPI[Webkit]Margin.cpp, which implements CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2648703002
Cr-Original-Commit-Position: refs/heads/master@{#447430}
Committed:
https://chromium.googlesource.com/chromium/src/+/72f22e3a5858ab9593cea5703c84...
Review-Url: https://codereview.chromium.org/2648703002
Cr-Commit-Position: refs/heads/master@{#447473}
Committed:
https://chromium.googlesource.com/chromium/src/+/bd564cefdfd28db390dcde233aa9...
==========

[commit-bot: I haz the power, 2017-02-01 08:23:08]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/bd564cefdfd28db390dcde233aa9...