Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2635773003: Implement Win 10 onboarding content logic (Closed)

Created:
3 years, 11 months ago by tmartino
Modified:
3 years, 11 months ago
Reviewers:
Patrick Monette
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Implement Win 10 onboarding content logic The onboarding content is a set of startup promo pages that are shown at most once to the user. Also adds a pref to remember if the Win10 promo page has been seen. BUG=648686 NOTRY=true NOPRESUBMIT=true TBR=pmonette@chromium.org Review-Url: https://codereview.chromium.org/2578843002 Cr-Commit-Position: refs/heads/master@{#439236} (cherry picked from commit ab0bd29c2204b4c28d4aef9024bd44074710eb76) Review-Url: https://codereview.chromium.org/2635773003 Cr-Commit-Position: refs/branch-heads/2924@{#773} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/61b53645e5a7503f03e0cf66870cd936176c0d99

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -19 lines) Patch
M chrome/browser/ui/startup/startup_browser_creator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/startup/startup_tab_provider.h View 2 chunks +18 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_tab_provider.cc View 3 chunks +49 lines, -14 lines 0 comments Download
M chrome/browser/ui/startup/startup_tab_provider_unittest.cc View 1 chunk +77 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/welcome_win10_ui.cc View 3 chunks +8 lines, -1 line 0 comments Download
M chrome/common/pref_names.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2635773003/1
3 years, 11 months ago (2017-01-16 16:28:10 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 16:33:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/61b53645e5a7503f03e0cf66870c...

Powered by Google App Engine
This is Rietveld 408576698