Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 2578843002: Implement Win 10 onboarding content logic (Closed)

Created:
4 years ago by Patrick Monette
Modified:
4 years ago
Reviewers:
tmartino, Peter Kasting
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement Win 10 onboarding content logic The onboarding content is a set of startup promo pages that are shown at most once to the user. Also adds a pref to remember if the Win10 promo page has been seen. BUG=648686 Committed: https://crrev.com/ab0bd29c2204b4c28d4aef9024bd44074710eb76 Cr-Commit-Position: refs/heads/master@{#439236}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Pref to local state #

Total comments: 2

Patch Set 3 : Dont delete UseConsolidatedFlow() #

Total comments: 4

Patch Set 4 : Fixed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -19 lines) Patch
M chrome/browser/ui/startup/startup_browser_creator.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/startup/startup_tab_provider.h View 1 2 3 2 chunks +18 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_tab_provider.cc View 1 3 chunks +49 lines, -14 lines 0 comments Download
M chrome/browser/ui/startup/startup_tab_provider_unittest.cc View 1 chunk +77 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/welcome_win10_ui.cc View 3 chunks +8 lines, -1 line 0 comments Download
M chrome/common/pref_names.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
tmartino
https://codereview.chromium.org/2578843002/diff/1/chrome/browser/ui/startup/startup_browser_creator.cc File chrome/browser/ui/startup/startup_browser_creator.cc (right): https://codereview.chromium.org/2578843002/diff/1/chrome/browser/ui/startup/startup_browser_creator.cc#newcode494 chrome/browser/ui/startup/startup_browser_creator.cc:494: registry->RegisterBooleanPref(prefs::kHasSeenWin10PromoPage, false); Per talking with Eli and Rachel, let's ...
4 years ago (2016-12-15 16:41:29 UTC) #3
Patrick Monette
https://codereview.chromium.org/2578843002/diff/1/chrome/browser/ui/startup/startup_browser_creator.cc File chrome/browser/ui/startup/startup_browser_creator.cc (right): https://codereview.chromium.org/2578843002/diff/1/chrome/browser/ui/startup/startup_browser_creator.cc#newcode494 chrome/browser/ui/startup/startup_browser_creator.cc:494: registry->RegisterBooleanPref(prefs::kHasSeenWin10PromoPage, false); On 2016/12/15 16:41:28, tmartino wrote: > Per ...
4 years ago (2016-12-15 18:28:09 UTC) #4
tmartino
lgtm one more thing, otherwise LGTM https://codereview.chromium.org/2578843002/diff/20001/chrome/browser/ui/startup/startup_browser_creator_impl.cc File chrome/browser/ui/startup/startup_browser_creator_impl.cc (left): https://codereview.chromium.org/2578843002/diff/20001/chrome/browser/ui/startup/startup_browser_creator_impl.cc#oldcode284 chrome/browser/ui/startup/startup_browser_creator_impl.cc:284: bool UseConsolidatedFlow() { ...
4 years ago (2016-12-15 19:00:10 UTC) #5
Patrick Monette
Hi Peter, PTAL https://codereview.chromium.org/2578843002/diff/20001/chrome/browser/ui/startup/startup_browser_creator_impl.cc File chrome/browser/ui/startup/startup_browser_creator_impl.cc (left): https://codereview.chromium.org/2578843002/diff/20001/chrome/browser/ui/startup/startup_browser_creator_impl.cc#oldcode284 chrome/browser/ui/startup/startup_browser_creator_impl.cc:284: bool UseConsolidatedFlow() { On 2016/12/15 19:00:10, ...
4 years ago (2016-12-15 20:17:35 UTC) #7
Peter Kasting
LGTM Please update the CL description to give a summary of what "Implement Win 10 ...
4 years ago (2016-12-16 08:53:55 UTC) #8
Patrick Monette
Thanks! https://codereview.chromium.org/2578843002/diff/40001/chrome/browser/ui/startup/startup_tab_provider.h File chrome/browser/ui/startup/startup_tab_provider.h (right): https://codereview.chromium.org/2578843002/diff/40001/chrome/browser/ui/startup/startup_tab_provider.h#newcode68 chrome/browser/ui/startup/startup_tab_provider.h:68: #if defined(OS_WIN) On 2016/12/16 08:53:55, Peter Kasting wrote: ...
4 years ago (2016-12-16 19:02:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2578843002/60001
4 years ago (2016-12-16 21:48:38 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-16 23:56:19 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-17 00:00:16 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ab0bd29c2204b4c28d4aef9024bd44074710eb76
Cr-Commit-Position: refs/heads/master@{#439236}

Powered by Google App Engine
This is Rietveld 408576698