Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: chrome/browser/ui/startup/startup_tab_provider_unittest.cc

Issue 2635773003: Implement Win 10 onboarding content logic (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/startup/startup_tab_provider.cc ('k') | chrome/browser/ui/webui/welcome_win10_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/startup/startup_tab_provider_unittest.cc
diff --git a/chrome/browser/ui/startup/startup_tab_provider_unittest.cc b/chrome/browser/ui/startup/startup_tab_provider_unittest.cc
index 38c34f2fbbea939dd809815951b80e46a4d0ac0e..98139b926c1e7f0731cfef7d0b4be0e938e34578 100644
--- a/chrome/browser/ui/startup/startup_tab_provider_unittest.cc
+++ b/chrome/browser/ui/startup/startup_tab_provider_unittest.cc
@@ -41,6 +41,83 @@ TEST(StartupTabProviderTest, CheckStandardOnboardingTabPolicy_Negative) {
EXPECT_TRUE(output.empty());
}
+#if defined(OS_WIN)
+TEST(StartupTabProviderTest, CheckWin10OnboardingTabPolicy) {
+ // Show Win 10 Welcome page if it has not been seen, but the standard page
+ // has.
+ StartupTabs output = StartupTabProviderImpl::CheckWin10OnboardingTabPolicy(
+ true, true, false, false, false);
+
+ ASSERT_EQ(1U, output.size());
+ EXPECT_EQ(StartupTabProviderImpl::GetWin10WelcomePageUrl(false),
+ output[0].url);
+ EXPECT_FALSE(output[0].is_pinned);
+
+ // Show standard Welcome page if the Win 10 Welcome page has been seen, but
+ // the standard page has not.
+ output = StartupTabProviderImpl::CheckWin10OnboardingTabPolicy(
+ true, false, true, false, false);
+
+ ASSERT_EQ(1U, output.size());
+ EXPECT_EQ(StartupTabProviderImpl::GetWelcomePageUrl(false), output[0].url);
+ EXPECT_FALSE(output[0].is_pinned);
+
+ // If neither page has been seen, the Win 10 Welcome page takes precedence
+ // this launch.
+ output = StartupTabProviderImpl::CheckWin10OnboardingTabPolicy(
+ true, false, false, false, false);
+
+ ASSERT_EQ(1U, output.size());
+ EXPECT_EQ(StartupTabProviderImpl::GetWin10WelcomePageUrl(false),
+ output[0].url);
+ EXPECT_FALSE(output[0].is_pinned);
+}
+
+TEST(StartupTabProviderTest, CheckWin10OnboardingTabPolicy_LaterRunVariant) {
+ // Show a variant of the Win 10 Welcome page after first run, if it has not
+ // been seen.
+ StartupTabs output = StartupTabProviderImpl::CheckWin10OnboardingTabPolicy(
+ false, false, false, false, false);
+
+ ASSERT_EQ(1U, output.size());
+ EXPECT_EQ(StartupTabProviderImpl::GetWin10WelcomePageUrl(true),
+ output[0].url);
+ EXPECT_FALSE(output[0].is_pinned);
+
+ // Show a variant of the standard Welcome page after first run, if the Win 10
+ // Welcome page has already been seen but the standard has not.
+ output = StartupTabProviderImpl::CheckWin10OnboardingTabPolicy(
+ false, false, true, false, false);
+
+ ASSERT_EQ(1U, output.size());
+ EXPECT_EQ(StartupTabProviderImpl::GetWelcomePageUrl(true), output[0].url);
+ EXPECT_FALSE(output[0].is_pinned);
+}
+
+TEST(StartupTabProviderTest, CheckWin10OnboardingTabPolicy_Negative) {
+ // Do not show either page if it has already been shown.
+ StartupTabs output = StartupTabProviderImpl::CheckWin10OnboardingTabPolicy(
+ true, true, true, false, false);
+
+ EXPECT_TRUE(output.empty());
+
+ // If Chrome is already the default browser, don't show the Win 10 Welcome
+ // page, and don't preempt the standard Welcome page.
+ output = StartupTabProviderImpl::CheckWin10OnboardingTabPolicy(
+ true, false, false, false, true);
+
+ ASSERT_EQ(1U, output.size());
+ EXPECT_EQ(StartupTabProviderImpl::GetWelcomePageUrl(false), output[0].url);
+ EXPECT_FALSE(output[0].is_pinned);
+
+ // If the user is signed in, block showing the standard Welcome page.
+ output = StartupTabProviderImpl::CheckWin10OnboardingTabPolicy(
+ true, false, true, true, false);
+
+ EXPECT_TRUE(output.empty());
+}
+#endif
+
TEST(StartupTabProviderTest, CheckMasterPrefsTabPolicy) {
std::vector<GURL> input = {GURL(base::ASCIIToUTF16("https://new_tab_page")),
GURL(base::ASCIIToUTF16("https://www.google.com")),
« no previous file with comments | « chrome/browser/ui/startup/startup_tab_provider.cc ('k') | chrome/browser/ui/webui/welcome_win10_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698