Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 2635473003: Optimize sending sys info to the feedback app (Closed)

Created:
3 years, 11 months ago by afakhry
Modified:
3 years, 11 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Optimize sending sys info to the feedback app This change optimizes the processing of sys info before sending it to the feedback app. It shaves off 10ms from that time on peach_pit. BUG=681279 Review-Url: https://codereview.chromium.org/2635473003 Cr-Commit-Position: refs/heads/master@{#444113} Committed: https://chromium.googlesource.com/chromium/src/+/701e43f0444b6bd25f7a58acb5ebe87138ffec04

Patch Set 1 #

Total comments: 5

Patch Set 2 : Xiyuan's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -74 lines) Patch
M chrome/browser/chromeos/feedback_util.cc View 1 chunk +6 lines, -12 lines 0 comments Download
M chrome/browser/extensions/api/feedback_private/feedback_private_api.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/feedback_private/feedback_private_api.cc View 1 3 chunks +24 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/feedback_private/feedback_service.h View 4 chunks +2 lines, -12 lines 0 comments Download
M chrome/browser/extensions/api/feedback_private/feedback_service.cc View 3 chunks +2 lines, -33 lines 0 comments Download
M chrome/browser/feedback/system_logs/system_logs_fetcher_base.h View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
afakhry
Xiyuan, could you please review this CL? Thanks.
3 years, 11 months ago (2017-01-17 17:54:42 UTC) #6
xiyuan
https://codereview.chromium.org/2635473003/diff/1/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc File chrome/browser/extensions/api/feedback_private/feedback_private_api.cc (right): https://codereview.chromium.org/2635473003/diff/1/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc#newcode235 chrome/browser/extensions/api/feedback_private/feedback_private_api.cc:235: &FeedbackPrivateGetSystemInformationFunction::OnCompleted, this)); Is this Bind safe? |service| and |this| ...
3 years, 11 months ago (2017-01-17 18:38:15 UTC) #7
afakhry
https://codereview.chromium.org/2635473003/diff/1/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc File chrome/browser/extensions/api/feedback_private/feedback_private_api.cc (right): https://codereview.chromium.org/2635473003/diff/1/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc#newcode235 chrome/browser/extensions/api/feedback_private/feedback_private_api.cc:235: &FeedbackPrivateGetSystemInformationFunction::OnCompleted, this)); On 2017/01/17 18:38:14, xiyuan wrote: > Is ...
3 years, 11 months ago (2017-01-17 18:51:13 UTC) #9
xiyuan
lgtm https://codereview.chromium.org/2635473003/diff/1/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc File chrome/browser/extensions/api/feedback_private/feedback_private_api.cc (right): https://codereview.chromium.org/2635473003/diff/1/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc#newcode235 chrome/browser/extensions/api/feedback_private/feedback_private_api.cc:235: &FeedbackPrivateGetSystemInformationFunction::OnCompleted, this)); On 2017/01/17 18:51:13, afakhry wrote: > ...
3 years, 11 months ago (2017-01-17 19:15:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2635473003/20001
3 years, 11 months ago (2017-01-17 19:22:31 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 19:48:34 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/701e43f0444b6bd25f7a58acb5eb...

Powered by Google App Engine
This is Rietveld 408576698