Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3379)

Unified Diff: chrome/browser/feedback/system_logs/system_logs_fetcher_base.h

Issue 2635473003: Optimize sending sys info to the feedback app (Closed)
Patch Set: Xiyuan's comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/feedback_private/feedback_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/feedback/system_logs/system_logs_fetcher_base.h
diff --git a/chrome/browser/feedback/system_logs/system_logs_fetcher_base.h b/chrome/browser/feedback/system_logs/system_logs_fetcher_base.h
index 9526da16449bcf58281796781071bad7be577d63..0aa92fab066503fcc0e7ce443b9f05ba09fa0f34 100644
--- a/chrome/browser/feedback/system_logs/system_logs_fetcher_base.h
+++ b/chrome/browser/feedback/system_logs/system_logs_fetcher_base.h
@@ -15,18 +15,18 @@
#include "base/macros.h"
#include "base/memory/scoped_vector.h"
#include "base/memory/weak_ptr.h"
+#include "components/feedback/feedback_common.h"
namespace system_logs {
-typedef std::map<std::string, std::string> SystemLogsResponse;
+using SystemLogsResponse = FeedbackCommon::SystemLogsMap;
// Callback that the data sources use to return data.
-typedef base::Callback<void(SystemLogsResponse* response)>
- SysLogsSourceCallback;
+using SysLogsSourceCallback = base::Callback<void(SystemLogsResponse*)>;
// Callback that the SystemLogsFetcherBase uses to return data.
-typedef base::Callback<void(std::unique_ptr<SystemLogsResponse> response)>
- SysLogsFetcherCallback;
+using SysLogsFetcherCallback =
+ base::Callback<void(std::unique_ptr<SystemLogsResponse>)>;
// The SystemLogsSource provides a interface for the data sources that
// the SystemLogsFetcherBase class uses to fetch logs and other
« no previous file with comments | « chrome/browser/extensions/api/feedback_private/feedback_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698