Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: chrome/browser/extensions/api/feedback_private/feedback_service.h

Issue 2635473003: Optimize sending sys info to the feedback app (Closed)
Patch Set: Xiyuan's comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/feedback_private/feedback_service.h
diff --git a/chrome/browser/extensions/api/feedback_private/feedback_service.h b/chrome/browser/extensions/api/feedback_private/feedback_service.h
index 9ada19476683ec344d0ae1fb5dda65fd13f4029b..e0b44055f41a2f98da87fb9492a0358647c5e3b7 100644
--- a/chrome/browser/extensions/api/feedback_private/feedback_service.h
+++ b/chrome/browser/extensions/api/feedback_private/feedback_service.h
@@ -14,16 +14,12 @@
#include "base/memory/weak_ptr.h"
#include "chrome/browser/extensions/blob_reader.h"
#include "chrome/browser/feedback/system_logs/scrubbed_system_logs_fetcher.h"
-#include "chrome/common/extensions/api/feedback_private.h"
#include "components/feedback/feedback_data.h"
class Profile;
namespace extensions {
-using SystemInformationList =
- std::vector<api::feedback_private::SystemInformation>;
-
// The feedback service provides the ability to gather the various pieces of
// data needed to send a feedback report and then send the report once all
// the pieces are available.
@@ -35,9 +31,6 @@ class FeedbackService : public base::SupportsWeakPtr<FeedbackService> {
// offline).
using SendFeedbackCallback = base::Callback<void(bool)>;
- using GetSystemInformationCallback =
- base::Callback<void(const SystemInformationList&)>;
-
FeedbackService();
virtual ~FeedbackService();
@@ -48,7 +41,8 @@ class FeedbackService : public base::SupportsWeakPtr<FeedbackService> {
// Start to gather system information.
// The |callback| will be invoked once the query is completed.
- void GetSystemInformation(const GetSystemInformationCallback& callback);
+ void GetSystemInformation(
+ const system_logs::SysLogsFetcherCallback& callback);
private:
// Callbacks to receive blob data.
@@ -61,10 +55,6 @@ class FeedbackService : public base::SupportsWeakPtr<FeedbackService> {
std::unique_ptr<std::string> data,
int64_t total_blob_length);
- void OnSystemLogsFetchComplete(
- const GetSystemInformationCallback& callback,
- std::unique_ptr<system_logs::SystemLogsResponse> sys_info);
-
// Checks if we have read all the blobs we need to; signals the feedback
// data object once all the requisite data has been populated.
void CompleteSendFeedback(scoped_refptr<feedback::FeedbackData> feedback_data,

Powered by Google App Engine
This is Rietveld 408576698