Chromium Code Reviews
DescriptionRevert of [Editing] Introduce |CompositeEditCommand::willApplyEditing()| in prepare for 'beforeinput' (1/3) (patchset #2 id:40001 of https://codereview.chromium.org/2583993002/ )
Reason for revert:
We want to revert all CLs and start over the refactor process, see:
https://crbug.com/673789.
Original issue's description:
> [Editing] Introduce |CompositeEditCommand::willApplyEditing()| in prepare for 'beforeinput' (1/3)
>
> This is the first sub-patch (1/3) of unifying 'beforeinput' logic. (Original CL
> https://crrev.com/2558643003)
>
> This CL:
> 1. Added attribute |m_inputType| to |TypingCommand|
> 2. Added calling path |CompositeEditCommand::apply()| =>
> *|CompositeEditCommand::willApply()| =>
> *|CompositeEditCommand::willApplyEditing()|
> 3. Added calling path |static TypingCommand::deleteSelection()/insertText()/...| =>
> *|TypingCommand::willAddTypingToOpenCommand()| =>
> *|CompositeEditCommand::willApplyEditing()|
>
> * Marks new methods.
>
> The next step is to move 'beforeinput' logic to
> |CompositeEditCommand::willApplyEditing()|.
>
> This CL shouldn't have any behavior change.
>
> To help reviewing, here is a simple doc describing the following plans:
> https://docs.google.com/a/chromium.org/document/d/1M9bQaLKdRpR1qJ9i7zZKN-hKwd4ZkgJs5GPde2ZsDy0/edit?usp=sharing
>
> BUG=670035
>
> Committed: https://crrev.com/4d0f52c1162dae46a7902527775f2a95fc972423
> Cr-Commit-Position: refs/heads/master@{#439633}
TBR=tkent@chromium.org,xiaochengh@chromium.org,yosin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=670035
Review-Url: https://codereview.chromium.org/2634633002
Cr-Commit-Position: refs/heads/master@{#443942}
Committed: https://chromium.googlesource.com/chromium/src/+/8fa239362956ce98ce4bd9f3b540050231a33179
Patch Set 1 #
Messages
Total messages: 11 (6 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||