Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2634633002: Revert of [Editing] Introduce |CompositeEditCommand::willApplyEditing()| in prepare for (1/3) (Closed)

Created:
3 years, 11 months ago by chongz
Modified:
3 years, 11 months ago
Reviewers:
tkent, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Editing] Introduce |CompositeEditCommand::willApplyEditing()| in prepare for 'beforeinput' (1/3) (patchset #2 id:40001 of https://codereview.chromium.org/2583993002/ ) Reason for revert: We want to revert all CLs and start over the refactor process, see: https://crbug.com/673789. Original issue's description: > [Editing] Introduce |CompositeEditCommand::willApplyEditing()| in prepare for 'beforeinput' (1/3) > > This is the first sub-patch (1/3) of unifying 'beforeinput' logic. (Original CL > https://crrev.com/2558643003) > > This CL: > 1. Added attribute |m_inputType| to |TypingCommand| > 2. Added calling path |CompositeEditCommand::apply()| => > *|CompositeEditCommand::willApply()| => > *|CompositeEditCommand::willApplyEditing()| > 3. Added calling path |static TypingCommand::deleteSelection()/insertText()/...| => > *|TypingCommand::willAddTypingToOpenCommand()| => > *|CompositeEditCommand::willApplyEditing()| > > * Marks new methods. > > The next step is to move 'beforeinput' logic to > |CompositeEditCommand::willApplyEditing()|. > > This CL shouldn't have any behavior change. > > To help reviewing, here is a simple doc describing the following plans: > https://docs.google.com/a/chromium.org/document/d/1M9bQaLKdRpR1qJ9i7zZKN-hKwd4ZkgJs5GPde2ZsDy0/edit?usp=sharing > > BUG=670035 > > Committed: https://crrev.com/4d0f52c1162dae46a7902527775f2a95fc972423 > Cr-Commit-Position: refs/heads/master@{#439633} TBR=tkent@chromium.org,xiaochengh@chromium.org,yosin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=670035 Review-Url: https://codereview.chromium.org/2634633002 Cr-Commit-Position: refs/heads/master@{#443942} Committed: https://chromium.googlesource.com/chromium/src/+/8fa239362956ce98ce4bd9f3b540050231a33179

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -92 lines) Patch
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 3 chunks +2 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.h View 3 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp View 11 chunks +30 lines, -68 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
chongz
Created Revert of [Editing] Introduce |CompositeEditCommand::willApplyEditing()| in prepare for 'beforeinput' (1/3)
3 years, 11 months ago (2017-01-13 20:58:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634633002/1
3 years, 11 months ago (2017-01-13 21:00:51 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/135818) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 11 months ago (2017-01-13 21:03:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634633002/1
3 years, 11 months ago (2017-01-16 19:40:08 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 21:07:30 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8fa239362956ce98ce4bd9f3b540...

Powered by Google App Engine
This is Rietveld 408576698