Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Unified Diff: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

Issue 2634633002: Revert of [Editing] Introduce |CompositeEditCommand::willApplyEditing()| in prepare for (1/3) (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
index 8e9f33a1e1d1e1348aee20a445f9137a3502cd4a..e5bd64d18911c0fdada87faebfc8e658c3a56331 100644
--- a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
@@ -187,7 +187,8 @@
DCHECK(isTopLevelCommand() || !m_composition);
}
-bool CompositeEditCommand::apply(EditCommandSource source) {
+// TODO(chongz): Fire 'beforeinput' based on |EditCommandSource|.
+bool CompositeEditCommand::apply(EditCommandSource) {
DCHECK(!isCommandGroupWrapper());
if (!endingSelection().isContentRichlyEditable()) {
switch (inputType()) {
@@ -223,9 +224,6 @@
// the creation of VisiblePositions).
document().updateStyleAndLayoutIgnorePendingStylesheets();
- if (!willApplyEditing(source))
- return false;
-
LocalFrame* frame = document().frame();
DCHECK(frame);
EditingState editingState;
@@ -250,11 +248,6 @@
command->m_composition = EditCommandComposition::create(
&document(), startingSelection(), endingSelection(), inputType());
return command->m_composition.get();
-}
-
-bool CompositeEditCommand::willApplyEditing(EditCommandSource) {
- // TODO(chongz): Move all the 'beforeinput' dispatching logic here.
- return true;
}
bool CompositeEditCommand::preservesTypingStyle() const {

Powered by Google App Engine
This is Rietveld 408576698