Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: third_party/WebKit/Source/core/editing/commands/TypingCommand.h

Issue 2634633002: Revert of [Editing] Introduce |CompositeEditCommand::willApplyEditing()| in prepare for (1/3) (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/TypingCommand.h
diff --git a/third_party/WebKit/Source/core/editing/commands/TypingCommand.h b/third_party/WebKit/Source/core/editing/commands/TypingCommand.h
index ecc6a3df2097432c17d46c927a6ed7a77490a758..49242a6bc4405b9ea382348852ab1b920c6dc62f 100644
--- a/third_party/WebKit/Source/core/editing/commands/TypingCommand.h
+++ b/third_party/WebKit/Source/core/editing/commands/TypingCommand.h
@@ -107,7 +107,8 @@
ETypingCommand commandTypeOfOpenCommand() const { return m_commandType; }
TextCompositionType compositionType() const { return m_compositionType; }
- // Returns text data of the last added typing.
+ // |TypingCommand| may contain multiple |InsertTextCommand|, should return
+ // |textDataForInputEvent()| of the last one.
String textDataForInputEvent() const final;
private:
@@ -159,10 +160,6 @@
LocalFrame*);
void updatePreservesTypingStyle(ETypingCommand);
- // Returns |false| to cancel adding typing.
- bool willAddTypingToOpenCommand(EditCommandSource,
- InputEvent::InputType,
- const String& text = nullAtom);
void typingAddedToOpenCommand(ETypingCommand);
bool makeEditableRootEmpty(EditingState*);
@@ -174,7 +171,6 @@
ETypingCommand m_commandType;
String m_textToInsert;
- InputEvent::InputType m_inputType;
bool m_openForMoreTyping;
bool m_selectInsertedText;
bool m_smartDelete;

Powered by Google App Engine
This is Rietveld 408576698