Animates touch points on screen tap during touch calibration

Animates touch points on screen tap during touch calibration
    
  - Animates the touch point when the user taps the screen during
    calibration.
  - Updates the dimensions of the certain UX elements based on updated
    mocks.
    
BUG=634166
COMPONENT=Touch Calibration, ChromeOS, UI Strings

Review-Url: https://codereview.chromium.org/2634553003
Cr-Commit-Position: refs/heads/master@{#443781}
Committed: https://chromium.googlesource.com/chromium/src/+/5671bf116d315cb3a5d4b0d25c1d0e168d90779d

[malaykeshav, 2017-01-14 01:19:35]

Description was changed from

==========
Animating touch points through all 4 locations

BUG=
==========

to

==========
Animates touch points on screen tap
    
  - Animates the touch point when the user taps the screen during
    calibration.
  - Updates the dimensions of the certain UX elements based on updated
    mocks.
    
BUG=634166
COMPONENT=Touch Calibration, ChromeOS, UI Strings
==========

[malaykeshav, 2017-01-14 01:19:39]

Patchset #1 (id:1) has been deleted

[malaykeshav, 2017-01-14 01:22:08]

malaykeshav@chromium.org changed reviewers:
+ oshima@chromium.org

[malaykeshav, 2017-01-14 01:22:09]

PTAL

[malaykeshav, 2017-01-14 01:22:13]

Patchset #1 (id:20001) has been deleted

[malaykeshav, 2017-01-14 01:22:16]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-14 01:22:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[malaykeshav, 2017-01-14 01:24:54]

Description was changed from

==========
Animates touch points on screen tap
    
  - Animates the touch point when the user taps the screen during
    calibration.
  - Updates the dimensions of the certain UX elements based on updated
    mocks.
    
BUG=634166
COMPONENT=Touch Calibration, ChromeOS, UI Strings
==========

to

==========
Animates touch points on screen tap during touch calibration
    
  - Animates the touch point when the user taps the screen during
    calibration.
  - Updates the dimensions of the certain UX elements based on updated
    mocks.
    
BUG=634166
COMPONENT=Touch Calibration, ChromeOS, UI Strings
==========

[oshima, 2017-01-14 01:39:45]

https://codereview.chromium.org/2634553003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.cc
(right):

https://codereview.chromium.org/2634553003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.cc:37:
const SkColor kTapHereLabelColor = SkColorSetARGBInline(255, 255, 255, 255);
 SK_ColorWHITE ?

https://codereview.chromium.org/2634553003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.cc:402:
views::Background::CreateSolidBackground(0, 0, 0, 0));
nit: can you use  CreateSolidBackground(SK_ColorTRANSPARENT)?

https://codereview.chromium.org/2634553003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.cc:514:
gfx::Point end_position_value;
Do either
1) inline the point 
2) set the duration in switch , then call AnimateLayerToPosition after switch.

https://codereview.chromium.org/2634553003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.cc:573:
return false;
Can you let the caller skip calling?

https://codereview.chromium.org/2634553003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.cc:577:
return false;
nit: you need {}

[malaykeshav, 2017-01-14 01:59:39]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-14 01:59:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[malaykeshav, 2017-01-14 02:00:34]

PTAL
Resolved comments

https://codereview.chromium.org/2634553003/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.cc
(right):

https://codereview.chromium.org/2634553003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.cc:37:
const SkColor kTapHereLabelColor = SkColorSetARGBInline(255, 255, 255, 255);
On 2017/01/14 at 01:39:45, oshima wrote:
> SK_ColorWHITE ?

Done

https://codereview.chromium.org/2634553003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.cc:402:
views::Background::CreateSolidBackground(0, 0, 0, 0));
On 2017/01/14 at 01:39:45, oshima wrote:
> nit: can you use  CreateSolidBackground(SK_ColorTRANSPARENT)?

Done

https://codereview.chromium.org/2634553003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.cc:514:
gfx::Point end_position_value;
On 2017/01/14 at 01:39:45, oshima wrote:
> Do either
> 1) inline the point 
> 2) set the duration in switch , then call AnimateLayerToPosition after switch.

Inlining

https://codereview.chromium.org/2634553003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.cc:573:
return false;
On 2017/01/14 at 01:39:45, oshima wrote:
> Can you let the caller skip calling?

Replacing with DCHECK

https://codereview.chromium.org/2634553003/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.cc:577:
return false;
On 2017/01/14 at 01:39:45, oshima wrote:
> nit: you need {}

Done

[commit-bot: I haz the power, 2017-01-14 02:51:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-14 02:51:47]

Dry run: This issue passed the CQ dry run.

[oshima, 2017-01-14 03:38:55]

lgtm

[malaykeshav, 2017-01-14 03:39:53]

The CQ bit was checked by malaykeshav@chromium.org

[commit-bot: I haz the power, 2017-01-14 03:40:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-14 03:44:56]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484365193737810,
"parent_rev": "ed7c87b8816f37e73f640e3b7c5c93fad0dbd29a", "commit_rev":
"5671bf116d315cb3a5d4b0d25c1d0e168d90779d"}

[commit-bot: I haz the power, 2017-01-14 03:45:33]

Description was changed from

==========
Animates touch points on screen tap during touch calibration
    
  - Animates the touch point when the user taps the screen during
    calibration.
  - Updates the dimensions of the certain UX elements based on updated
    mocks.
    
BUG=634166
COMPONENT=Touch Calibration, ChromeOS, UI Strings
==========

to

==========
Animates touch points on screen tap during touch calibration
    
  - Animates the touch point when the user taps the screen during
    calibration.
  - Updates the dimensions of the certain UX elements based on updated
    mocks.
    
BUG=634166
COMPONENT=Touch Calibration, ChromeOS, UI Strings

Review-Url: https://codereview.chromium.org/2634553003
Cr-Commit-Position: refs/heads/master@{#443781}
Committed:
https://chromium.googlesource.com/chromium/src/+/5671bf116d315cb3a5d4b0d25c1d...
==========

[commit-bot: I haz the power, 2017-01-14 03:45:34]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/5671bf116d315cb3a5d4b0d25c1d...