Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.cc

Issue 2634553003: Animates touch points on screen tap during touch calibration (Closed)
Patch Set: Resolving Comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.cc
diff --git a/chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.cc b/chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.cc
index 2f56fa51d053371764c02202099b7018024a62cd..dd980bdc7f947ce9b793f6eee34d19725bb8ee1a 100644
--- a/chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.cc
+++ b/chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.cc
@@ -125,6 +125,10 @@ void TouchCalibratorController::OnTouchEvent(ui::TouchEvent* touch) {
if (target_screen_calibration_view->GetDisplayPointLocation(&display_point)) {
touch_point_quad_[state_index] =
std::make_pair(display_point, touch->location());
+ } else {
+ // TODO(malaykeshav): Display some kind of error for the user.
+ NOTREACHED() << "Touch calibration failed. Could not retrieve location for"
+ " display point. Retry calibration.";
}
// If this is the final state, then store all calibration data and stop
« no previous file with comments | « no previous file | chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698