Displays the calibration complete message to touch calibration and gracefully quits

Displays the calibration complete message to touch calibration and gracefully quits

 - Adds calibration complete icon and message.
 - Fades out the overlay and gracefully quits touch calibration.
 - Updates minor UI specs including:
   - Animation duration for translation
   - Opacity of throbber circle
 - Adds SetForCalibration(bool) method for touch transform
   controller which enables the use of raw untransformed
   touch input during calibration.

Preview:
https://drive.google.com/open?id=0B_WkX8bSkoT1X1BpbnJPNGR6QXc

BUG=634166
COMPONENT=Touch Calibration, ChromeOS, UI Strings, Ash vector icons

Review-Url: https://codereview.chromium.org/2633423004
Cr-Commit-Position: refs/heads/master@{#444263}
Committed: https://chromium.googlesource.com/chromium/src/+/2b2ffba88b9e72c314558f6072692b5483ad66dd

[malaykeshav, 2017-01-17 22:18:33]

Description was changed from

==========
Displays the calibration complete message to touch calibration and gracefully
quits

 - Adds calibration complete icon and message.
 - Fades out the overlay and gracefully quits touch calibration.

BUG=634166
COMPONENT=Touch Calibration, ChromeOS, UI Strings, Ash vector icons
==========

to

==========
Displays the calibration complete message to touch calibration and gracefully
quits

 - Adds calibration complete icon and message.
 - Fades out the overlay and gracefully quits touch calibration.

Preview:
https://drive.google.com/open?id=0B_WkX8bSkoT1X1BpbnJPNGR6QXc

BUG=634166
COMPONENT=Touch Calibration, ChromeOS, UI Strings, Ash vector icons
==========

[malaykeshav, 2017-01-17 22:20:40]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 22:21:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[malaykeshav, 2017-01-17 23:05:20]

Patchset #2 (id:20001) has been deleted

[malaykeshav, 2017-01-17 23:05:51]

Patchset #1 (id:1) has been deleted

[malaykeshav, 2017-01-17 23:06:27]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[malaykeshav, 2017-01-17 23:07:17]

malaykeshav@chromium.org changed reviewers:
+ oshima@chromium.org

[malaykeshav, 2017-01-17 23:07:17]

PTAL

[commit-bot: I haz the power, 2017-01-17 23:07:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[malaykeshav, 2017-01-17 23:18:34]

Description was changed from

==========
Displays the calibration complete message to touch calibration and gracefully
quits

 - Adds calibration complete icon and message.
 - Fades out the overlay and gracefully quits touch calibration.

Preview:
https://drive.google.com/open?id=0B_WkX8bSkoT1X1BpbnJPNGR6QXc

BUG=634166
COMPONENT=Touch Calibration, ChromeOS, UI Strings, Ash vector icons
==========

to

==========
Displays the calibration complete message to touch calibration and gracefully
quits

 - Adds calibration complete icon and message.
 - Fades out the overlay and gracefully quits touch calibration.
 - Updates minor UI specs including:
   - Animation duration for translation
   - Opacity of throbber circle

Preview:
https://drive.google.com/open?id=0B_WkX8bSkoT1X1BpbnJPNGR6QXc

BUG=634166
COMPONENT=Touch Calibration, ChromeOS, UI Strings, Ash vector icons
==========

[commit-bot: I haz the power, 2017-01-18 00:15:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 00:15:44]

Dry run: This issue passed the CQ dry run.

[malaykeshav, 2017-01-18 00:20:14]

Patchset #2 (id:60001) has been deleted

[malaykeshav, 2017-01-18 00:25:18]

Patchset #2 (id:80001) has been deleted

[malaykeshav, 2017-01-18 00:26:48]

Patchset #2 (id:100001) has been deleted

[malaykeshav, 2017-01-18 00:27:17]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 00:28:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[malaykeshav, 2017-01-18 00:29:32]

Description was changed from

==========
Displays the calibration complete message to touch calibration and gracefully
quits

 - Adds calibration complete icon and message.
 - Fades out the overlay and gracefully quits touch calibration.
 - Updates minor UI specs including:
   - Animation duration for translation
   - Opacity of throbber circle

Preview:
https://drive.google.com/open?id=0B_WkX8bSkoT1X1BpbnJPNGR6QXc

BUG=634166
COMPONENT=Touch Calibration, ChromeOS, UI Strings, Ash vector icons
==========

to

==========
Displays the calibration complete message to touch calibration and gracefully
quits

 - Adds calibration complete icon and message.
 - Fades out the overlay and gracefully quits touch calibration.
 - Updates minor UI specs including:
   - Animation duration for translation
   - Opacity of throbber circle
 - Adds SetForCalibration(bool) method for touch transform
   controller which enables the use of raw untransformed
   touch input during calibration.

Preview:
https://drive.google.com/open?id=0B_WkX8bSkoT1X1BpbnJPNGR6QXc

BUG=634166
COMPONENT=Touch Calibration, ChromeOS, UI Strings, Ash vector icons
==========

[malaykeshav, 2017-01-18 00:30:16]

Adds a minor change:
  - Adds SetForCalibration(bool) method for touch transform
    controller which enables the use of raw un-transformed
    touch input during calibration.

PTAL

[commit-bot: I haz the power, 2017-01-18 01:37:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 01:37:12]

Dry run: This issue passed the CQ dry run.

[oshima, 2017-01-18 01:57:16]

https://codereview.chromium.org/2633423004/diff/120001/chrome/browser/chromeo...
File
chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.cc
(right):

https://codereview.chromium.org/2633423004/diff/120001/chrome/browser/chromeo...
chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.cc:56:
// TODO(malaykeshav): Call TouchTransformController::SetForCalibration()
nit: remove the comment?

https://codereview.chromium.org/2633423004/diff/120001/chrome/browser/chromeo...
File chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.cc
(right):

https://codereview.chromium.org/2633423004/diff/120001/chrome/browser/chromeo...
chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.cc:318:
CompletionMessageView(gfx::Rect bounds, base::string16 message);
nit: const & for both

https://codereview.chromium.org/2633423004/diff/120001/chrome/browser/chromeo...
chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.cc:330:
gfx::Point center_;
document these two.

https://codereview.chromium.org/2633423004/diff/120001/chrome/browser/chromeo...
chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.cc:571:
break;
You can do it in a separate CL, but you should use DIM layer.

[malaykeshav, 2017-01-18 02:08:39]

Resolved comments.
PTAL

https://codereview.chromium.org/2633423004/diff/120001/chrome/browser/chromeo...
File
chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.cc
(right):

https://codereview.chromium.org/2633423004/diff/120001/chrome/browser/chromeo...
chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.cc:56:
// TODO(malaykeshav): Call TouchTransformController::SetForCalibration()
On 2017/01/18 at 01:57:16, oshima wrote:
> nit: remove the comment?

Done

https://codereview.chromium.org/2633423004/diff/120001/chrome/browser/chromeo...
File chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.cc
(right):

https://codereview.chromium.org/2633423004/diff/120001/chrome/browser/chromeo...
chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.cc:318:
CompletionMessageView(gfx::Rect bounds, base::string16 message);
On 2017/01/18 at 01:57:16, oshima wrote:
> nit: const & for both

Done

https://codereview.chromium.org/2633423004/diff/120001/chrome/browser/chromeo...
chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.cc:330:
gfx::Point center_;
On 2017/01/18 at 01:57:16, oshima wrote:
> document these two.

No longer required.

https://codereview.chromium.org/2633423004/diff/120001/chrome/browser/chromeo...
chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.cc:571:
break;
On 2017/01/18 at 01:57:16, oshima wrote:
> You can do it in a separate CL, but you should use DIM layer.

Ack

[malaykeshav, 2017-01-18 02:08:42]

The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 02:09:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oshima, 2017-01-18 02:45:19]

lgtm

[commit-bot: I haz the power, 2017-01-18 03:12:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 03:12:27]

Dry run: This issue passed the CQ dry run.

[malaykeshav, 2017-01-18 03:52:35]

The CQ bit was checked by malaykeshav@chromium.org

[commit-bot: I haz the power, 2017-01-18 03:52:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 03:57:05]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1484711555714350,
"parent_rev": "fd10fe94ba828949dcddd148fb73c3797ab83ef3", "commit_rev":
"2b2ffba88b9e72c314558f6072692b5483ad66dd"}

[commit-bot: I haz the power, 2017-01-18 03:57:38]

Description was changed from

==========
Displays the calibration complete message to touch calibration and gracefully
quits

 - Adds calibration complete icon and message.
 - Fades out the overlay and gracefully quits touch calibration.
 - Updates minor UI specs including:
   - Animation duration for translation
   - Opacity of throbber circle
 - Adds SetForCalibration(bool) method for touch transform
   controller which enables the use of raw untransformed
   touch input during calibration.

Preview:
https://drive.google.com/open?id=0B_WkX8bSkoT1X1BpbnJPNGR6QXc

BUG=634166
COMPONENT=Touch Calibration, ChromeOS, UI Strings, Ash vector icons
==========

to

==========
Displays the calibration complete message to touch calibration and gracefully
quits

 - Adds calibration complete icon and message.
 - Fades out the overlay and gracefully quits touch calibration.
 - Updates minor UI specs including:
   - Animation duration for translation
   - Opacity of throbber circle
 - Adds SetForCalibration(bool) method for touch transform
   controller which enables the use of raw untransformed
   touch input during calibration.

Preview:
https://drive.google.com/open?id=0B_WkX8bSkoT1X1BpbnJPNGR6QXc

BUG=634166
COMPONENT=Touch Calibration, ChromeOS, UI Strings, Ash vector icons

Review-Url: https://codereview.chromium.org/2633423004
Cr-Commit-Position: refs/heads/master@{#444263}
Committed:
https://chromium.googlesource.com/chromium/src/+/2b2ffba88b9e72c314558f607269...
==========

[commit-bot: I haz the power, 2017-01-18 03:57:40]

Committed patchset #3 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/2b2ffba88b9e72c314558f607269...