Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2633423004: Displays the calibration complete message to touch calibration and gracefully quits (Closed)

Created:
3 years, 11 months ago by malaykeshav
Modified:
3 years, 11 months ago
Reviewers:
oshima
CC:
chromium-reviews, davemoore+watch_chromium.org, kalyank, oshima+watch_chromium.org, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Displays the calibration complete message to touch calibration and gracefully quits - Adds calibration complete icon and message. - Fades out the overlay and gracefully quits touch calibration. - Updates minor UI specs including: - Animation duration for translation - Opacity of throbber circle - Adds SetForCalibration(bool) method for touch transform controller which enables the use of raw untransformed touch input during calibration. Preview: https://drive.google.com/open?id=0B_WkX8bSkoT1X1BpbnJPNGR6QXc BUG=634166 COMPONENT=Touch Calibration, ChromeOS, UI Strings, Ash vector icons Review-Url: https://codereview.chromium.org/2633423004 Cr-Commit-Position: refs/heads/master@{#444263} Committed: https://chromium.googlesource.com/chromium/src/+/2b2ffba88b9e72c314558f6072692b5483ad66dd

Patch Set 1 : Displays the calibration complete message to touch calibration and gracefully quits #

Patch Set 2 : Small addition #

Total comments: 8

Patch Set 3 : Resolving comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -21 lines) Patch
M ash/resources/vector_icons/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A ash/resources/vector_icons/touch_calibration_complete_check.icon View 1 chunk +22 lines, -0 lines 0 comments Download
A ash/resources/vector_icons/touch_calibration_complete_check.1x.icon View 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.cc View 1 2 5 chunks +16 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.h View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.cc View 1 2 12 chunks +140 lines, -5 lines 0 comments Download
M ui/display/manager/chromeos/touch_transform_controller.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M ui/display/manager/chromeos/touch_transform_controller.cc View 1 2 chunks +10 lines, -0 lines 0 comments Download
M ui/strings/ui_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 33 (26 generated)
malaykeshav
PTAL
3 years, 11 months ago (2017-01-17 23:07:17 UTC) #8
malaykeshav
Adds a minor change: - Adds SetForCalibration(bool) method for touch transform controller which enables the ...
3 years, 11 months ago (2017-01-18 00:30:16 UTC) #19
oshima
https://codereview.chromium.org/2633423004/diff/120001/chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.cc File chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.cc (right): https://codereview.chromium.org/2633423004/diff/120001/chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.cc#newcode56 chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.cc:56: // TODO(malaykeshav): Call TouchTransformController::SetForCalibration() nit: remove the comment? https://codereview.chromium.org/2633423004/diff/120001/chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_view.cc ...
3 years, 11 months ago (2017-01-18 01:57:16 UTC) #22
malaykeshav
Resolved comments. PTAL https://codereview.chromium.org/2633423004/diff/120001/chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.cc File chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.cc (right): https://codereview.chromium.org/2633423004/diff/120001/chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.cc#newcode56 chrome/browser/chromeos/display/touch_calibrator/touch_calibrator_controller.cc:56: // TODO(malaykeshav): Call TouchTransformController::SetForCalibration() On 2017/01/18 ...
3 years, 11 months ago (2017-01-18 02:08:39 UTC) #23
oshima
lgtm
3 years, 11 months ago (2017-01-18 02:45:19 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2633423004/140001
3 years, 11 months ago (2017-01-18 03:52:50 UTC) #30
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 03:57:40 UTC) #33
Message was sent while issue was closed.
Committed patchset #3 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/2b2ffba88b9e72c314558f607269...

Powered by Google App Engine
This is Rietveld 408576698