[Android] Stop using universal_newlines in the layout tests server constructor. (RELAND)

[Android] Stop using universal_newlines in the layout tests server constructor. (RELAND)

This had previously been necessary when spawning adb instances with the
server constructor, as adb mangles newlines. Starting with
https://codereview.chromium.org/2540603004/, the android port no longer
spins up adb shells with the server constructor, so we no longer need to
use universal_newlines. This also means we no longer need to encode crash
streams back into bytes from text, as they're not converted to text in the
first place.

This is a reland of https://codereview.chromium.org/2629113005/

BUG=679723, 496983
TEST=fast/dom/shadow/gesture-tap-mouseup-listener-update-distribution-crash.html, which consistently crashes on android

Review-Url: https://codereview.chromium.org/2633753003
Cr-Commit-Position: refs/heads/master@{#443771}
Committed: https://chromium.googlesource.com/chromium/src/+/078991c0a621513fe78bde8822c7bc9f309e688d

[jbudorick, 2017-01-14 01:03:59]

Description was changed from

==========
[Android] Stop using universal_newlines in the layout tests server constructor.
(RELAND)

This had previously been necessary when spawning adb instances with the
server constructor, as adb mangles newlines. Starting with
https://codereview.chromium.org/2540603004/, the android port no longer
spins up adb shells with the server constructor, so we no longer need to
use universal_newlines. This also means we no longer need to encode crash
streams back into bytes from text, as they're not converted to text in the
first place.

BUG=679723,496983
==========

to

==========
[Android] Stop using universal_newlines in the layout tests server constructor.
(RELAND)

This had previously been necessary when spawning adb instances with the
server constructor, as adb mangles newlines. Starting with
https://codereview.chromium.org/2540603004/, the android port no longer
spins up adb shells with the server constructor, so we no longer need to
use universal_newlines. This also means we no longer need to encode crash
streams back into bytes from text, as they're not converted to text in the
first place.

BUG=679723,496983
TEST=fast/dom/shadow/gesture-tap-mouseup-listener-update-distribution-crash.html,
which consistently crashes on android
==========

[jbudorick, 2017-01-14 01:08:45]

Description was changed from

==========
[Android] Stop using universal_newlines in the layout tests server constructor.
(RELAND)

This had previously been necessary when spawning adb instances with the
server constructor, as adb mangles newlines. Starting with
https://codereview.chromium.org/2540603004/, the android port no longer
spins up adb shells with the server constructor, so we no longer need to
use universal_newlines. This also means we no longer need to encode crash
streams back into bytes from text, as they're not converted to text in the
first place.

BUG=679723,496983
TEST=fast/dom/shadow/gesture-tap-mouseup-listener-update-distribution-crash.html,
which consistently crashes on android
==========

to

==========
[Android] Stop using universal_newlines in the layout tests server constructor.
(RELAND)

This had previously been necessary when spawning adb instances with the
server constructor, as adb mangles newlines. Starting with
https://codereview.chromium.org/2540603004/, the android port no longer
spins up adb shells with the server constructor, so we no longer need to
use universal_newlines. This also means we no longer need to encode crash
streams back into bytes from text, as they're not converted to text in the
first place.

This is a reland of https://codereview.chromium.org/2629113005/

BUG=679723,496983
TEST=fast/dom/shadow/gesture-tap-mouseup-listener-update-distribution-crash.html,
which consistently crashes on android
==========

[jbudorick, 2017-01-14 01:09:07]

jbudorick@chromium.org changed reviewers:
+ jeffcarp@chromium.org, qyearsley@chromium.org

[jbudorick, 2017-01-14 01:09:07]

Let's try this again.

[Dirk Pranke, 2017-01-14 01:12:42]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2017-01-14 01:12:42]

lgtm

[jbudorick, 2017-01-14 01:13:31]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2017-01-14 01:14:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-14 02:20:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484356411525190,
"parent_rev": "c38f883945d7981f8c3fa0440579f5e56bb613ec", "commit_rev":
"078991c0a621513fe78bde8822c7bc9f309e688d"}

[commit-bot: I haz the power, 2017-01-14 02:21:02]

Description was changed from

==========
[Android] Stop using universal_newlines in the layout tests server constructor.
(RELAND)

This had previously been necessary when spawning adb instances with the
server constructor, as adb mangles newlines. Starting with
https://codereview.chromium.org/2540603004/, the android port no longer
spins up adb shells with the server constructor, so we no longer need to
use universal_newlines. This also means we no longer need to encode crash
streams back into bytes from text, as they're not converted to text in the
first place.

This is a reland of https://codereview.chromium.org/2629113005/

BUG=679723,496983
TEST=fast/dom/shadow/gesture-tap-mouseup-listener-update-distribution-crash.html,
which consistently crashes on android
==========

to

==========
[Android] Stop using universal_newlines in the layout tests server constructor.
(RELAND)

This had previously been necessary when spawning adb instances with the
server constructor, as adb mangles newlines. Starting with
https://codereview.chromium.org/2540603004/, the android port no longer
spins up adb shells with the server constructor, so we no longer need to
use universal_newlines. This also means we no longer need to encode crash
streams back into bytes from text, as they're not converted to text in the
first place.

This is a reland of https://codereview.chromium.org/2629113005/

BUG=679723,496983
TEST=fast/dom/shadow/gesture-tap-mouseup-listener-update-distribution-crash.html,
which consistently crashes on android

Review-Url: https://codereview.chromium.org/2633753003
Cr-Commit-Position: refs/heads/master@{#443771}
Committed:
https://chromium.googlesource.com/chromium/src/+/078991c0a621513fe78bde8822c7...
==========

[commit-bot: I haz the power, 2017-01-14 02:21:02]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/078991c0a621513fe78bde8822c7...