Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py

Issue 2633753003: [Android] Stop using universal_newlines in the layout tests server constructor. (RELAND) (Closed)
Patch Set: accept unicode and str objects Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py
index a582ebe4ff5d1e468808c955e3b3792830c2f4c7..6795b35d599fad11d1f2389ce89cff16089df450 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py
@@ -79,15 +79,12 @@ class ServerProcess(object):
as necessary to keep issuing commands.
"""
- def __init__(self, port_obj, name, cmd, env=None, universal_newlines=False, treat_no_data_as_crash=False,
+ def __init__(self, port_obj, name, cmd, env=None, treat_no_data_as_crash=False,
more_logging=False):
self._port = port_obj
self._name = name # Should be the command name (e.g. content_shell, image_diff)
self._cmd = cmd
self._env = env
- # Set if the process outputs non-standard newlines like '\r\n' or '\r'.
- # Don't set if there will be binary data or the data must be ASCII encoded.
- self._universal_newlines = universal_newlines
self._treat_no_data_as_crash = treat_no_data_as_crash
self._logging = more_logging
self._host = self._port.host
@@ -140,8 +137,7 @@ class ServerProcess(object):
stdout=self._host.executive.PIPE,
stderr=self._host.executive.PIPE,
close_fds=close_fds,
- env=self._env,
- universal_newlines=self._universal_newlines)
+ env=self._env)
self._pid = self._proc.pid
fd = self._proc.stdout.fileno()
if not self._use_win32_apis:

Powered by Google App Engine
This is Rietveld 408576698