third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process_mock.py - Issue 2633753003: [Android] Stop using universal_newlines in the layout tests server constructor. (RELAND)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process_mock.py

Issue 2633753003: [Android] Stop using universal_newlines in the layout tests server constructor. (RELAND) (Closed)

Patch Set: accept unicode and str objects Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process_mock.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process_mock.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process_mock.py

index 5a1633ad21257727313ff8747fb013fda4e42935..70ac65c89cb8cf7045aa31527453e11920bf790b 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process_mock.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process_mock.py

@@ -29,8 +29,12 @@

class MockServerProcess(object):

- def __init__(self, port_obj=None, name=None, cmd=None, env=None, universal_newlines=False,

- treat_no_data_as_crash=False, more_logging=False, lines=None, crashed=False):

+ def __init__(self, port_obj=None, name=None, cmd=None, env=None,

+ treat_no_data_as_crash=False, more_logging=False, lines=None,

+ crashed=False):

+ # port_obj and name are unused, but are maintained for compatibility

+ # with server_process.ServerProcess.

+ # pylint: disable=unused-argument

self.timed_out = False

self.lines = lines or ['#READY']

self.crashed = crashed

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py ('k') | no next file » | no next file with comments »