Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 2632123004: Add assert that only one of initial or inherit applyValueCSSPropertyVariable() (Closed)

Created:
3 years, 11 months ago by alancutter (OOO until 2018)
Modified:
3 years, 11 months ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add assert that only one of initial or inherit is true in applyValueCSSPropertyVariable() This assert was removed in https://codereview.chromium.org/2630683002. This patch adds it back as it's still worthwhile. BUG=671904 Review-Url: https://codereview.chromium.org/2632123004 Cr-Commit-Position: refs/heads/master@{#444002} Committed: https://chromium.googlesource.com/chromium/src/+/00cd466db74e724f2dda6fe6f9d583a0b964bbc5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
alancutter (OOO until 2018)
3 years, 11 months ago (2017-01-17 06:42:53 UTC) #2
Timothy Loh
On 2017/01/17 06:42:53, alancutter wrote: lgtm
3 years, 11 months ago (2017-01-17 06:43:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2632123004/1
3 years, 11 months ago (2017-01-17 06:46:37 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 08:08:39 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/00cd466db74e724f2dda6fe6f9d5...

Powered by Google App Engine
This is Rietveld 408576698