third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp - Issue 2632123004: Add assert that only one of initial or inherit applyValueCSSPropertyVariable()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

Issue 2632123004: Add assert that only one of initial or inherit applyValueCSSPropertyVariable() (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp b/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

index 9d67471662806ebae405f92442b995c1fb17ee1d..246dcc0c4728a16a9f4f2d5c98a109278deadedf 100644

--- a/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

@@ -927,6 +927,7 @@ void StyleBuilderFunctions::applyValueCSSPropertyVariable(

else

initial = true;

}

+ DCHECK(initial ^ inherit);

state.style()->removeVariable(name, isInheritedProperty);

if (initial) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »