Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2631553003: [inspector] console.timeEnd formats ms in the same way as JS formats double (Closed)

Created:
3 years, 11 months ago by kozy
Modified:
3 years, 11 months ago
Reviewers:
dgozman, alph, pfeldman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] console.timeEnd formats ms in the same way as JS formats double BUG=chromium:680801 R=dgozman@chromium.org,pfeldman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2631553003 Cr-Commit-Position: refs/heads/master@{#42427} Committed: https://chromium.googlesource.com/v8/v8/+/5d95b0a9b32fabbda745e55629aa5ce6dd8de4e9

Patch Set 1 #

Patch Set 2 : fixed test formatting #

Patch Set 3 : a #

Patch Set 4 : fixed test expectation #

Patch Set 5 : fixed protocol-works-with-different-locale test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -16 lines) Patch
M src/inspector/v8-console.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/inspector/inspector-impl.h View 2 chunks +5 lines, -0 lines 0 comments Download
M test/inspector/inspector-impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M test/inspector/inspector-test.cc View 5 chunks +26 lines, -1 line 0 comments Download
A test/inspector/runtime/console-time-end-format.js View 1 2 1 chunk +45 lines, -0 lines 0 comments Download
A test/inspector/runtime/console-time-end-format-expected.txt View 1 2 3 1 chunk +29 lines, -0 lines 0 comments Download
M test/inspector/runtime/protocol-works-with-different-locale.js View 1 2 3 4 3 chunks +10 lines, -10 lines 0 comments Download
M test/inspector/runtime/protocol-works-with-different-locale-expected.txt View 1 2 3 4 3 chunks +5 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (17 generated)
kozy
Dmitry and Pavel, please take a look.
3 years, 11 months ago (2017-01-13 18:11:04 UTC) #1
kozy
Alexei, please take a look! :)
3 years, 11 months ago (2017-01-17 00:05:35 UTC) #16
alph
lgtm
3 years, 11 months ago (2017-01-17 19:31:04 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2631553003/80001
3 years, 11 months ago (2017-01-17 19:51:58 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 20:21:43 UTC) #22
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/5d95b0a9b32fabbda745e55629aa5ce6dd8...

Powered by Google App Engine
This is Rietveld 408576698