[inspector] expose V8InspectorSession::breakProgram in test harness.

[inspector] expose V8InspectorSession::breakProgram in test harness.

V8InspectorSession::schedulePauseOnNextStatement and V8InspectorSession::cancelPauseOnNextStatement are now exposed in inspector tests. These methods are required at least for better blackboxing tests.

BUG=v8:5842
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2636613002
Cr-Commit-Position: refs/heads/master@{#42469}
Committed: https://chromium.googlesource.com/v8/v8/+/51740cc16a94f4327b9042369bf6dad537cc948c

[kozy, 2017-01-14 01:03:13]

Description was changed from

==========
[inspector] expose V8InspectorSession::breakProgram..

..V8InspectorSession::schedulePauseOnNextStatement and
V8InspectorSession::cancelPauseOnNextStatement for inspector tests. This methods
are required at least for better blackboxing tests.

BUG=
R=dgozman@chromium.org
==========

to

==========
[inspector] expose V8InspectorSession::breakProgram..

..V8InspectorSession::schedulePauseOnNextStatement and
V8InspectorSession::cancelPauseOnNextStatement for inspector tests. This methods
are required at least for better blackboxing tests.

BUG=v8:5842
R=dgozman@chromium.org
==========

[kozy, 2017-01-14 01:03:23]

Dmitry, please take a look.

[kozy, 2017-01-17 18:41:26]

Patchset #3 (id:40001) has been deleted

[dgozman, 2017-01-18 16:07:44]

Description was changed from

==========
[inspector] expose V8InspectorSession::breakProgram..

..V8InspectorSession::schedulePauseOnNextStatement and
V8InspectorSession::cancelPauseOnNextStatement for inspector tests. This methods
are required at least for better blackboxing tests.

BUG=v8:5842
R=dgozman@chromium.org
==========

to

==========
[inspector] expose V8InspectorSession::breakProgram in test harness.

..V8InspectorSession::schedulePauseOnNextStatement and
V8InspectorSession::cancelPauseOnNextStatement for inspector tests. This methods
are required at least for better blackboxing tests.

BUG=v8:5842
R=dgozman@chromium.org
==========

[dgozman, 2017-01-18 16:08:20]

Description was changed from

==========
[inspector] expose V8InspectorSession::breakProgram in test harness.

..V8InspectorSession::schedulePauseOnNextStatement and
V8InspectorSession::cancelPauseOnNextStatement for inspector tests. This methods
are required at least for better blackboxing tests.

BUG=v8:5842
R=dgozman@chromium.org
==========

to

==========
[inspector] expose V8InspectorSession::breakProgram in test harness.

V8InspectorSession::schedulePauseOnNextStatement and
V8InspectorSession::cancelPauseOnNextStatement are now exposed in inspector
tests. These methods are required at least for better blackboxing tests.

BUG=v8:5842
R=dgozman@chromium.org
==========

[dgozman, 2017-01-18 16:17:47]

lgtm

https://codereview.chromium.org/2636613002/diff/60001/test/inspector/debugger...
File test/inspector/debugger/inspector-break-api.js (right):

https://codereview.chromium.org/2636613002/diff/60001/test/inspector/debugger...
test/inspector/debugger/inspector-break-api.js:9: breakProgram('DOM',
JSON.stringify({a: 42}));
Why DOM?

[kozy, 2017-01-18 16:33:00]

thanks! all done.

https://codereview.chromium.org/2636613002/diff/60001/test/inspector/debugger...
File test/inspector/debugger/inspector-break-api.js (right):

https://codereview.chromium.org/2636613002/diff/60001/test/inspector/debugger...
test/inspector/debugger/inspector-break-api.js:9: breakProgram('DOM',
JSON.stringify({a: 42}));
On 2017/01/18 16:17:46, dgozman wrote:
> Why DOM?

Done.

[kozy, 2017-01-18 16:33:03]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-01-18 16:33:03]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2636613002/#ps80001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-01-18 16:33:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 16:57:02]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484757183491780,
"parent_rev": "d794ef7db5de8ebcbd6182923c960b23bffbaadd", "commit_rev":
"51740cc16a94f4327b9042369bf6dad537cc948c"}

[commit-bot: I haz the power, 2017-01-18 16:57:06]

Description was changed from

==========
[inspector] expose V8InspectorSession::breakProgram in test harness.

V8InspectorSession::schedulePauseOnNextStatement and
V8InspectorSession::cancelPauseOnNextStatement are now exposed in inspector
tests. These methods are required at least for better blackboxing tests.

BUG=v8:5842
R=dgozman@chromium.org
==========

to

==========
[inspector] expose V8InspectorSession::breakProgram in test harness.

V8InspectorSession::schedulePauseOnNextStatement and
V8InspectorSession::cancelPauseOnNextStatement are now exposed in inspector
tests. These methods are required at least for better blackboxing tests.

BUG=v8:5842
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2636613002
Cr-Commit-Position: refs/heads/master@{#42469}
Committed:
https://chromium.googlesource.com/v8/v8/+/51740cc16a94f4327b9042369bf6dad537c...
==========

[commit-bot: I haz the power, 2017-01-18 16:57:07]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/51740cc16a94f4327b9042369bf6dad537c...