Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Unified Diff: test/inspector/runtime/protocol-works-with-different-locale.js

Issue 2631553003: [inspector] console.timeEnd formats ms in the same way as JS formats double (Closed)
Patch Set: fixed protocol-works-with-different-locale test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/inspector/runtime/protocol-works-with-different-locale.js
diff --git a/test/inspector/runtime/protocol-works-with-different-locale.js b/test/inspector/runtime/protocol-works-with-different-locale.js
index 381dfab31eb2ac16ac15917b022cb8ea15c9de67..27be5ed9053fb23f4025db9c681a6e9720f3037d 100644
--- a/test/inspector/runtime/protocol-works-with-different-locale.js
+++ b/test/inspector/runtime/protocol-works-with-different-locale.js
@@ -4,7 +4,7 @@
Protocol.Runtime.enable();
-Protocol.Runtime.onConsoleAPICalled(dumpConsoleApiCalled);
+Protocol.Runtime.onConsoleAPICalled(InspectorTest.logMessage);
InspectorTest.runTestSuite([
function consoleLogWithDefaultLocale(next) {
@@ -14,7 +14,11 @@ InspectorTest.runTestSuite([
function consoleTimeWithCommaAsSeparator(next) {
InspectorTest.log("set locale to fr_CA.UTF-8 (has comma as separator)");
setlocale("fr_CA.UTF-8");
- Protocol.Runtime.evaluate({ expression: "console.time(\"a\"); console.timeEnd(\"a\")"}).then(next);
+ setCurrentTimeMSForTest(0.0);
+ Protocol.Runtime.evaluate({ expression: "console.time(\"a\");"})
+ .then(() => setCurrentTimeMSForTest(0.001))
+ .then(() => Protocol.Runtime.evaluate({ expression: "console.timeEnd(\"a\");"}))
+ .then(next);
},
function consoleLogWithCommaAsSeparator(next) {
@@ -27,14 +31,10 @@ InspectorTest.runTestSuite([
InspectorTest.log("set locale to fr_CA.UTF-8 (has comma as separator)");
setlocale("fr_CA.UTF-8");
Protocol.Runtime.evaluate({ expression: "console.log(239) "})
- .then(() => Protocol.Runtime.evaluate({ expression: "console.time(\"a\"); console.timeEnd(\"a\")"}))
+ .then(() => setCurrentTimeMSForTest(0.0))
+ .then(() => Protocol.Runtime.evaluate({ expression: "console.time(\"a\");"}))
+ .then(() => setCurrentTimeMSForTest(0.001))
+ .then(() => Protocol.Runtime.evaluate({ expression: "console.timeEnd(\"a\");"}))
.then(next);
}
]);
-
-function dumpConsoleApiCalled(message) {
- var firstArg = message.params.args[0];
- if (firstArg.type === "string")
- firstArg.value = firstArg.value.replace(/[0-9]+/g, "x");
- InspectorTest.logMessage(message);
-}

Powered by Google App Engine
This is Rietveld 408576698