Reland of Stop bad results on first memory benchmark run

Reland of Stop bad results on first memory benchmark run (patchset #1 id:1 of https://codereview.chromium.org/2627323002/ )

Reason for revert:
Now that the crash in telemetry Olivia stopped (thanks Olivia!) has been fixed: https://codereview.chromium.org/2623423005/ and that fix has rolled into chromium https://codereview.chromium.org/2622363009 the original patch ought to now work.




Original issue's description:
> Revert of Stop bad results on first memory benchmark run (patchset #8 id:140001 of https://codereview.chromium.org/2589173004/ )
> 
> Reason for revert:
> Suspecting that this CL is causing many failures on benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.
> 
> Example builds:
> 
> https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/11962
> https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/6323
> 
> Original issue's description:
> > Stop bad results on first memory benchmark run
> > 
> > The first memory system-health story ran in a set has been reporting
> > memory use differently all subsequent runs. This is due to how we
> > flush the system caches.
> > 
> > Just before we measure memory we flush the system caches unfortunately
> > this doesn't immediately take effect, instead the next story run is
> > effected. Due to this the first story run has anomalous results.
> > This option causes us to flush caches each time before Chrome starts
> > so we effect even the first story - avoiding the bug.
> > 
> > *************** Note to Perf Sheriff ****************
> > 
> > Regressions across several memory metrics are
> > expected for system_health.memory_mobile, 
> > system_health.memory_desktop and memory.top10_mobile
> > as we stop under counting memory use.
> > 
> > *****************************************************
> > 
> > BUG=chromium:671156
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq
> > 
> > Review-Url: https://codereview.chromium.org/2589173004
> > Cr-Commit-Position: refs/heads/master@{#443273}
> > Committed: https://chromium.googlesource.com/chromium/src/+/3afb7e7da06df087b3e9fac2ae68593f75a051ed
> 
> TBR=perezju@chromium.org,nednguyen@google.com,hjd@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:671156
> 
> Review-Url: https://codereview.chromium.org/2627323002
> Cr-Commit-Position: refs/heads/master@{#443323}
> Committed: https://chromium.googlesource.com/chromium/src/+/36f123b0599822932e4c62c350448b961957c9ea

TBR=perezju@chromium.org,nednguyen@google.com,xlai@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:671156
Review-Url: https://codereview.chromium.org/2631283002
Cr-Commit-Position: refs/heads/master@{#444051}
Committed: https://chromium.googlesource.com/chromium/src/+/593ea0410890854382a2df7cd58400208410a89a

[hjd, 2017-01-16 18:09:37]

Created Reland of Stop bad results on first memory benchmark run

[hjd, 2017-01-16 18:14:41]

The CQ bit was checked by hjd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 18:14:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 19:37:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 19:37:39]

Dry run: This issue passed the CQ dry run.

[hjd, 2017-01-17 11:31:32]

@perezju: I think we're okay to reland this now? ptal, thanks! :)

[perezju, 2017-01-17 13:12:35]

lgtm, yes go ahead

[hjd, 2017-01-17 14:50:55]

The CQ bit was checked by hjd@chromium.org

[commit-bot: I haz the power, 2017-01-17 14:51:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 14:54:53]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484664655148440, "parent_rev":
"b20f0039e91883b8f001390a2f21616b4ec5752d", "commit_rev":
"593ea0410890854382a2df7cd58400208410a89a"}

[commit-bot: I haz the power, 2017-01-17 14:55:21]

Description was changed from

==========
Reland of Stop bad results on first memory benchmark run (patchset #1 id:1 of
https://codereview.chromium.org/2627323002/ )

Reason for revert:
Now that the crash in telemetry Olivia stopped (thanks Olivia!) has been fixed:
https://codereview.chromium.org/2623423005/ and that fix has rolled into
chromium https://codereview.chromium.org/2622363009 the original patch ought to
now work.




Original issue's description:
> Revert of Stop bad results on first memory benchmark run (patchset #8
id:140001 of https://codereview.chromium.org/2589173004/ )
> 
> Reason for revert:
> Suspecting that this CL is causing many failures on
benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.
> 
> Example builds:
> 
>
https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/11962
>
https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/6323
> 
> Original issue's description:
> > Stop bad results on first memory benchmark run
> > 
> > The first memory system-health story ran in a set has been reporting
> > memory use differently all subsequent runs. This is due to how we
> > flush the system caches.
> > 
> > Just before we measure memory we flush the system caches unfortunately
> > this doesn't immediately take effect, instead the next story run is
> > effected. Due to this the first story run has anomalous results.
> > This option causes us to flush caches each time before Chrome starts
> > so we effect even the first story - avoiding the bug.
> > 
> > *************** Note to Perf Sheriff ****************
> > 
> > Regressions across several memory metrics are
> > expected for system_health.memory_mobile, 
> > system_health.memory_desktop and memory.top10_mobile
> > as we stop under counting memory use.
> > 
> > *****************************************************
> > 
> > BUG=chromium:671156
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq
> > 
> > Review-Url: https://codereview.chromium.org/2589173004
> > Cr-Commit-Position: refs/heads/master@{#443273}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/3afb7e7da06df087b3e9fac2ae68...
> 
> TBR=perezju@chromium.org,nednguyen@google.com,hjd@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:671156
> 
> Review-Url: https://codereview.chromium.org/2627323002
> Cr-Commit-Position: refs/heads/master@{#443323}
> Committed:
https://chromium.googlesource.com/chromium/src/+/36f123b0599822932e4c62c35044...

TBR=perezju@chromium.org,nednguyen@google.com,xlai@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:671156
==========

to

==========
Reland of Stop bad results on first memory benchmark run (patchset #1 id:1 of
https://codereview.chromium.org/2627323002/ )

Reason for revert:
Now that the crash in telemetry Olivia stopped (thanks Olivia!) has been fixed:
https://codereview.chromium.org/2623423005/ and that fix has rolled into
chromium https://codereview.chromium.org/2622363009 the original patch ought to
now work.




Original issue's description:
> Revert of Stop bad results on first memory benchmark run (patchset #8
id:140001 of https://codereview.chromium.org/2589173004/ )
> 
> Reason for revert:
> Suspecting that this CL is causing many failures on
benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.
> 
> Example builds:
> 
>
https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/11962
>
https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/6323
> 
> Original issue's description:
> > Stop bad results on first memory benchmark run
> > 
> > The first memory system-health story ran in a set has been reporting
> > memory use differently all subsequent runs. This is due to how we
> > flush the system caches.
> > 
> > Just before we measure memory we flush the system caches unfortunately
> > this doesn't immediately take effect, instead the next story run is
> > effected. Due to this the first story run has anomalous results.
> > This option causes us to flush caches each time before Chrome starts
> > so we effect even the first story - avoiding the bug.
> > 
> > *************** Note to Perf Sheriff ****************
> > 
> > Regressions across several memory metrics are
> > expected for system_health.memory_mobile, 
> > system_health.memory_desktop and memory.top10_mobile
> > as we stop under counting memory use.
> > 
> > *****************************************************
> > 
> > BUG=chromium:671156
> >
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq
> > 
> > Review-Url: https://codereview.chromium.org/2589173004
> > Cr-Commit-Position: refs/heads/master@{#443273}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/3afb7e7da06df087b3e9fac2ae68...
> 
> TBR=perezju@chromium.org,nednguyen@google.com,hjd@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:671156
> 
> Review-Url: https://codereview.chromium.org/2627323002
> Cr-Commit-Position: refs/heads/master@{#443323}
> Committed:
https://chromium.googlesource.com/chromium/src/+/36f123b0599822932e4c62c35044...

TBR=perezju@chromium.org,nednguyen@google.com,xlai@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:671156

Review-Url: https://codereview.chromium.org/2631283002
Cr-Commit-Position: refs/heads/master@{#444051}
Committed:
https://chromium.googlesource.com/chromium/src/+/593ea0410890854382a2df7cd584...
==========

[commit-bot: I haz the power, 2017-01-17 14:55:22]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/593ea0410890854382a2df7cd584...