Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2627323002: Revert of Stop bad results on first memory benchmark run (Closed)

Created:
3 years, 11 months ago by xlai (Olivia)
Modified:
3 years, 11 months ago
Reviewers:
perezju, hjd, nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Stop bad results on first memory benchmark run (patchset #8 id:140001 of https://codereview.chromium.org/2589173004/ ) Reason for revert: Suspecting that this CL is causing many failures on benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest. Example builds: https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/11962 https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/6323 Original issue's description: > Stop bad results on first memory benchmark run > > The first memory system-health story ran in a set has been reporting > memory use differently all subsequent runs. This is due to how we > flush the system caches. > > Just before we measure memory we flush the system caches unfortunately > this doesn't immediately take effect, instead the next story run is > effected. Due to this the first story run has anomalous results. > This option causes us to flush caches each time before Chrome starts > so we effect even the first story - avoiding the bug. > > *************** Note to Perf Sheriff **************** > > Regressions across several memory metrics are > expected for system_health.memory_mobile, > system_health.memory_desktop and memory.top10_mobile > as we stop under counting memory use. > > ***************************************************** > > BUG=chromium:671156 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq > > Review-Url: https://codereview.chromium.org/2589173004 > Cr-Commit-Position: refs/heads/master@{#443273} > Committed: https://chromium.googlesource.com/chromium/src/+/3afb7e7da06df087b3e9fac2ae68593f75a051ed TBR=perezju@chromium.org,nednguyen@google.com,hjd@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:671156 Review-Url: https://codereview.chromium.org/2627323002 Cr-Commit-Position: refs/heads/master@{#443323} Committed: https://chromium.googlesource.com/chromium/src/+/36f123b0599822932e4c62c350448b961957c9ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M tools/perf/benchmarks/memory.py View 1 chunk +0 lines, -9 lines 0 comments Download
M tools/perf/benchmarks/system_health.py View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
xlai (Olivia)
Created Revert of Stop bad results on first memory benchmark run
3 years, 11 months ago (2017-01-12 19:28:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627323002/1
3 years, 11 months ago (2017-01-12 19:29:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/36f123b0599822932e4c62c350448b961957c9ea
3 years, 11 months ago (2017-01-12 19:30:48 UTC) #6
perezju
On 2017/01/12 19:30:48, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 11 months ago (2017-01-13 09:16:39 UTC) #7
hjd
3 years, 11 months ago (2017-01-16 18:09:36 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2631283002/ by hjd@chromium.org.

The reason for reverting is: Now that the crash in telemetry Olivia stopped
(thanks Olivia!) has been fixed: https://codereview.chromium.org/2623423005/ and
that fix has rolled into chromium https://codereview.chromium.org/2622363009 the
original patch ought to now work.


.

Powered by Google App Engine
This is Rietveld 408576698