DescriptionRevert of Stop bad results on first memory benchmark run (patchset #8 id:140001 of https://codereview.chromium.org/2589173004/ )
Reason for revert:
Suspecting that this CL is causing many failures on benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.
Example builds:
https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/11962
https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/6323
Original issue's description:
> Stop bad results on first memory benchmark run
>
> The first memory system-health story ran in a set has been reporting
> memory use differently all subsequent runs. This is due to how we
> flush the system caches.
>
> Just before we measure memory we flush the system caches unfortunately
> this doesn't immediately take effect, instead the next story run is
> effected. Due to this the first story run has anomalous results.
> This option causes us to flush caches each time before Chrome starts
> so we effect even the first story - avoiding the bug.
>
> *************** Note to Perf Sheriff ****************
>
> Regressions across several memory metrics are
> expected for system_health.memory_mobile,
> system_health.memory_desktop and memory.top10_mobile
> as we stop under counting memory use.
>
> *****************************************************
>
> BUG=chromium:671156
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq
>
> Review-Url: https://codereview.chromium.org/2589173004
> Cr-Commit-Position: refs/heads/master@{#443273}
> Committed: https://chromium.googlesource.com/chromium/src/+/3afb7e7da06df087b3e9fac2ae68593f75a051ed
TBR=perezju@chromium.org,nednguyen@google.com,hjd@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:671156
Review-Url: https://codereview.chromium.org/2627323002
Cr-Commit-Position: refs/heads/master@{#443323}
Committed: https://chromium.googlesource.com/chromium/src/+/36f123b0599822932e4c62c350448b961957c9ea
Patch Set 1 #
Messages
Total messages: 8 (3 generated)
|