Fix the order in which the iOS Tab Switcher cells are initialized.

Fix the order in which the iOS Tab Switcher cells are initialized.

The delegate of the cell is used in |setAppearanceForTab:cellSize:| to obtain the
snapshot.
https://codereview.chromium.org/2615883002 incorrectly moved the initialization of
the delegate after the call to |setAppearanceForTab:cellSize:|. This CL fixes that.

BUG=680474
Review-Url: https://codereview.chromium.org/2631233002
Cr-Commit-Position: refs/heads/master@{#444013}
Committed: https://chromium.googlesource.com/chromium/src/+/bc8c881127daf08a8c857e55f465699ed32bcb44

[jif, 2017-01-16 17:32:57]

Patchset #1 (id:1) has been deleted

[jif, 2017-01-16 17:36:41]

Description was changed from

==========
Foo.

BUG=None.
==========

to

==========
Fix the order in which the iOS Tab Switcher cells are initialized.

The delegate of the cell is used in |setAppearanceForTab:cellSize:| to obtain
the
snapshot.
https://codereview.chromium.org/2615883002 incorrectly moved the initialization
of
the delegate after the call to |setAppearanceForTab:cellSize:|. This CL fixes
that.

BUG=680474
==========

[jif, 2017-01-16 17:37:37]

jif@chromium.org changed reviewers:
+ lpromero@chromium.org

[jif, 2017-01-16 17:37:47]

ptal

[lpromero, 2017-01-16 18:03:21]

lgtm

https://codereview.chromium.org/2631233002/diff/20001/ios/chrome/browser/ui/t...
File ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.mm (right):

https://codereview.chromium.org/2631233002/diff/20001/ios/chrome/browser/ui/t...
ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.mm:233: DCHECK([self
cache]);
Can you add a comment in the header for setAppearance to require a delegate set?
Would it make sense to DCHECK(self.delegate) in -cache then?

[jif-google, 2017-01-16 19:09:55]

On 2017/01/16 18:03:21, lpromero wrote:
> lgtm
> 
>
https://codereview.chromium.org/2631233002/diff/20001/ios/chrome/browser/ui/t...
> File ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.mm (right):
> 
>
https://codereview.chromium.org/2631233002/diff/20001/ios/chrome/browser/ui/t...
> ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.mm:233:
DCHECK([self
> cache]);
> Can you add a comment in the header for setAppearance to require a delegate
set?
Yes.

> Would it make sense to DCHECK(self.delegate) in -cache then?
Calling -cache when the delegate is nil shouldn't be forbidden: it's possible
that the cell is not on the screen anymore, and that the delegate has been
unset.

[jif, 2017-01-17 09:30:47]

thank you

[jif, 2017-01-17 09:30:51]

The CQ bit was checked by jif@chromium.org

[jif, 2017-01-17 09:30:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2631233002/#ps40001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2017-01-17 09:31:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 09:39:46]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484645451214210,
"parent_rev": "926f68b50b6b096adf88ab47a252a406561b51bf", "commit_rev":
"bc8c881127daf08a8c857e55f465699ed32bcb44"}

[commit-bot: I haz the power, 2017-01-17 09:40:13]

Description was changed from

==========
Fix the order in which the iOS Tab Switcher cells are initialized.

The delegate of the cell is used in |setAppearanceForTab:cellSize:| to obtain
the
snapshot.
https://codereview.chromium.org/2615883002 incorrectly moved the initialization
of
the delegate after the call to |setAppearanceForTab:cellSize:|. This CL fixes
that.

BUG=680474
==========

to

==========
Fix the order in which the iOS Tab Switcher cells are initialized.

The delegate of the cell is used in |setAppearanceForTab:cellSize:| to obtain
the
snapshot.
https://codereview.chromium.org/2615883002 incorrectly moved the initialization
of
the delegate after the call to |setAppearanceForTab:cellSize:|. This CL fixes
that.

BUG=680474

Review-Url: https://codereview.chromium.org/2631233002
Cr-Commit-Position: refs/heads/master@{#444013}
Committed:
https://chromium.googlesource.com/chromium/src/+/bc8c881127daf08a8c857e55f465...
==========

[commit-bot: I haz the power, 2017-01-17 09:40:14]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bc8c881127daf08a8c857e55f465...