Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 2631233002: Fix the order in which the iOS Tab Switcher cells are initialized. (Closed)

Created:
3 years, 11 months ago by jif
Modified:
3 years, 11 months ago
Reviewers:
lpromero
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the order in which the iOS Tab Switcher cells are initialized. The delegate of the cell is used in |setAppearanceForTab:cellSize:| to obtain the snapshot. https://codereview.chromium.org/2615883002 incorrectly moved the initialization of the delegate after the call to |setAppearanceForTab:cellSize:|. This CL fixes that. BUG=680474 Review-Url: https://codereview.chromium.org/2631233002 Cr-Commit-Position: refs/heads/master@{#444013} Committed: https://chromium.googlesource.com/chromium/src/+/bc8c881127daf08a8c857e55f465699ed32bcb44

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.mm View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_controller.mm View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
jif
ptal
3 years, 11 months ago (2017-01-16 17:37:47 UTC) #4
lpromero
lgtm https://codereview.chromium.org/2631233002/diff/20001/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.mm File ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.mm (right): https://codereview.chromium.org/2631233002/diff/20001/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.mm#newcode233 ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.mm:233: DCHECK([self cache]); Can you add a comment in ...
3 years, 11 months ago (2017-01-16 18:03:21 UTC) #5
jif-google
On 2017/01/16 18:03:21, lpromero wrote: > lgtm > > https://codereview.chromium.org/2631233002/diff/20001/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.mm > File ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.mm (right): > ...
3 years, 11 months ago (2017-01-16 19:09:55 UTC) #6
jif
thank you
3 years, 11 months ago (2017-01-17 09:30:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2631233002/40001
3 years, 11 months ago (2017-01-17 09:31:04 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 09:40:14 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bc8c881127daf08a8c857e55f465...

Powered by Google App Engine
This is Rietveld 408576698