ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.mm - Issue 2631233002: Fix the order in which the iOS Tab Switcher cells are initialized.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.mm

Issue 2631233002: Fix the order in which the iOS Tab Switcher cells are initialized. (Closed)

Patch Set: Addressed comments. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.mm

diff --git a/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.mm b/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.mm

index 1bd0b37542d00c85ac81ed7c85cf73c081e4c8f1..bad9ca219e0c990b13e27012ce3e851739f969fa 100644

--- a/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.mm

+++ b/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.mm

@@ -230,6 +230,8 @@ CGFloat tabSwitcherLocalSessionCellTopBarHeight() {

CGSize snapshotSize = cellSize;

snapshotSize.height -= tabSwitcherLocalSessionCellTopBarHeight();

base::WeakNSObject<TabSwitcherLocalSessionCell> weakCell(self);

+ DCHECK(self.delegate);

+ DCHECK([self cache]);

_currentPendingSnapshotRequest =

[[self cache] requestSnapshotForTab:tab

withSize:snapshotSize