Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 2615883002: Fix for voice-over accessibility issue with tab switcher. (Closed)

Created:
3 years, 11 months ago by sdefresne
Modified:
3 years, 11 months ago
CC:
chromium-reviews, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for voice-over accessibility issue with tab switcher. When a cell is removed from the collection view with a custom action, the accessibility does not drop the custom action. This crashed the application as the -deleteButtonPressedForCell: method assumed that it would only ever be called with cell in the collection. Work-around this by posting a UIAccessibilityScreenChangedNotification which force accessibility to re-inspect everything (thus dropping the selection custom action) and by also resetting the delegate on the cell (not really necessary but cleaner). BUG=677374 Review-Url: https://codereview.chromium.org/2615883002 Cr-Commit-Position: refs/heads/master@{#441649} Committed: https://chromium.googlesource.com/chromium/src/+/e90f8871ccbf3df4fcef6960dd60756c559abcbe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -34 lines) Patch
M ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.h View 3 chunks +3 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.mm View 7 chunks +7 lines, -15 lines 0 comments Download
M ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_controller.mm View 5 chunks +31 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
sdefresne
Please take a look.
3 years, 11 months ago (2017-01-05 14:00:29 UTC) #4
noyau (Ping after 24h)
lgtm. Thanks.
3 years, 11 months ago (2017-01-05 14:06:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615883002/1
3 years, 11 months ago (2017-01-05 14:23:09 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 14:26:59 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e90f8871ccbf3df4fcef6960dd60...

Powered by Google App Engine
This is Rietveld 408576698