Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1812)

Issue 2630763002: Revert of Remove support for GlobalNetworkClientFactory from RequestTracker. (Closed)

Created:
3 years, 11 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 11 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove support for GlobalNetworkClientFactory from RequestTracker. (patchset #1 id:1 of https://codereview.chromium.org/2633453004/ ) Reason for revert: Base CL breaks CroNet: https://codereview.chromium.org/2627973005 Original issue's description: > Remove support for GlobalNetworkClientFactory from RequestTracker. > > The method RequestTracker::AddGlobalNetworkClientFactory is never > called so remove the method and the support code. > > BUG=585700 > > Review-Url: https://codereview.chromium.org/2633453004 > Cr-Commit-Position: refs/heads/master@{#443591} > Committed: https://chromium.googlesource.com/chromium/src/+/12bd970214af9f7a2716037569df8261f565453a TBR=sdefresne@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=585700 Review-Url: https://codereview.chromium.org/2630763002 Cr-Commit-Position: refs/heads/master@{#443622} Committed: https://chromium.googlesource.com/chromium/src/+/de0a5c0273ea322431f88c0c3dbc333666ae1c30

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -0 lines) Patch
M ios/net/crn_http_protocol_handler.mm View 1 chunk +5 lines, -0 lines 0 comments Download
M ios/net/request_tracker.h View 2 chunks +12 lines, -0 lines 0 comments Download
M ios/net/request_tracker.mm View 3 chunks +72 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Eugene But (OOO till 7-30)
Created Revert of Remove support for GlobalNetworkClientFactory from RequestTracker.
3 years, 11 months ago (2017-01-13 18:36:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2630763002/1
3 years, 11 months ago (2017-01-13 18:37:18 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 18:38:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/de0a5c0273ea322431f88c0c3dbc...

Powered by Google App Engine
This is Rietveld 408576698