Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2633453004:
Remove support for GlobalNetworkClientFactory from RequestTracker. (Closed)
|
Created:
3 years, 11 months ago by sdefresne Modified:
3 years, 11 months ago Reviewers:
Eugene But (OOO till 7-30) CC:
chromium-reviews, cbentzel+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove support for GlobalNetworkClientFactory from RequestTracker.
The method RequestTracker::AddGlobalNetworkClientFactory is never
called so remove the method and the support code.
BUG=585700
Review-Url: https://codereview.chromium.org/2633453004
Cr-Original-Commit-Position: refs/heads/master@{#443591}
Committed: https://chromium.googlesource.com/chromium/src/+/12bd970214af9f7a2716037569df8261f565453a
Review-Url: https://codereview.chromium.org/2633453004
Cr-Commit-Position: refs/heads/master@{#444045}
Committed: https://chromium.googlesource.com/chromium/src/+/a237d0b9b2021a782f3c1004c7bc272c6266d418
Patch Set 1 #
Total comments: 1
Patch Set 2 : Rebase. #
Messages
Total messages: 26 (15 generated)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
sdefresne@chromium.org changed reviewers: + eugenebut@chromium.org
Please take a look. https://codereview.chromium.org/2633453004/diff/1/ios/net/crn_http_protocol_h... File ios/net/crn_http_protocol_handler.mm (left): https://codereview.chromium.org/2633453004/diff/1/ios/net/crn_http_protocol_h... ios/net/crn_http_protocol_handler.mm:670: PushClients(RequestTracker::GlobalClientsHandlingAnyRequest()); This method was always returning an empty NSArray, so I just removed the call to PushClients.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by eugenebut@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2627973005 Patch 1). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by sdefresne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1484327564776340, "parent_rev":
"20f7270f96d194b98f3053a1f5035552cf758c2c", "commit_rev":
"12bd970214af9f7a2716037569df8261f565453a"}
Message was sent while issue was closed.
Description was changed from ========== Remove support for GlobalNetworkClientFactory from RequestTracker. The method RequestTracker::AddGlobalNetworkClientFactory is never called so remove the method and the support code. BUG=585700 ========== to ========== Remove support for GlobalNetworkClientFactory from RequestTracker. The method RequestTracker::AddGlobalNetworkClientFactory is never called so remove the method and the support code. BUG=585700 Review-Url: https://codereview.chromium.org/2633453004 Cr-Commit-Position: refs/heads/master@{#443591} Committed: https://chromium.googlesource.com/chromium/src/+/12bd970214af9f7a2716037569df... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/12bd970214af9f7a2716037569df...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2630763002/ by eugenebut@chromium.org. The reason for reverting is: Base CL breaks CroNet: https://codereview.chromium.org/2627973005.
Message was sent while issue was closed.
Description was changed from ========== Remove support for GlobalNetworkClientFactory from RequestTracker. The method RequestTracker::AddGlobalNetworkClientFactory is never called so remove the method and the support code. BUG=585700 Review-Url: https://codereview.chromium.org/2633453004 Cr-Commit-Position: refs/heads/master@{#443591} Committed: https://chromium.googlesource.com/chromium/src/+/12bd970214af9f7a2716037569df... ========== to ========== Remove support for GlobalNetworkClientFactory from RequestTracker. The method RequestTracker::AddGlobalNetworkClientFactory is never called so remove the method and the support code. BUG=585700 Review-Url: https://codereview.chromium.org/2633453004 Cr-Commit-Position: refs/heads/master@{#443591} Committed: https://chromium.googlesource.com/chromium/src/+/12bd970214af9f7a2716037569df... ==========
On 2017/01/13 18:36:41, Eugene But wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/2630763002/ by mailto:eugenebut@chromium.org. > > The reason for reverting is: Base CL breaks CroNet: > https://codereview.chromium.org/2627973005. It looks like both CLs were in fact not related and this code is really unused and thus won't break CroNet. I'll try to reland without landing the base CL.
The CQ bit was checked by sdefresne@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eugenebut@chromium.org Link to the patchset: https://codereview.chromium.org/2633453004/#ps20001 (title: "Rebase.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484662799209340,
"parent_rev": "f71584603a72dacb606c3176f72b713856f49e29", "commit_rev":
"a237d0b9b2021a782f3c1004c7bc272c6266d418"}
Message was sent while issue was closed.
Description was changed from ========== Remove support for GlobalNetworkClientFactory from RequestTracker. The method RequestTracker::AddGlobalNetworkClientFactory is never called so remove the method and the support code. BUG=585700 Review-Url: https://codereview.chromium.org/2633453004 Cr-Commit-Position: refs/heads/master@{#443591} Committed: https://chromium.googlesource.com/chromium/src/+/12bd970214af9f7a2716037569df... ========== to ========== Remove support for GlobalNetworkClientFactory from RequestTracker. The method RequestTracker::AddGlobalNetworkClientFactory is never called so remove the method and the support code. BUG=585700 Review-Url: https://codereview.chromium.org/2633453004 Cr-Original-Commit-Position: refs/heads/master@{#443591} Committed: https://chromium.googlesource.com/chromium/src/+/12bd970214af9f7a2716037569df... Review-Url: https://codereview.chromium.org/2633453004 Cr-Commit-Position: refs/heads/master@{#444045} Committed: https://chromium.googlesource.com/chromium/src/+/a237d0b9b2021a782f3c1004c7bc... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/a237d0b9b2021a782f3c1004c7bc...
Message was sent while issue was closed.
On 2017/01/17 14:31:50, commit-bot: I haz the power wrote: > Committed patchset #2 (id:20001) as > https://chromium.googlesource.com/chromium/src/+/a237d0b9b2021a782f3c1004c7bc... I should not have CQed this CL so quickly. Sorry about that, Sylvain.
Message was sent while issue was closed.
On 2017/01/17 17:30:25, Eugene But wrote: > On 2017/01/17 14:31:50, commit-bot: I haz the power wrote: > > Committed patchset #2 (id:20001) as > > > https://chromium.googlesource.com/chromium/src/+/a237d0b9b2021a782f3c1004c7bc... > I should not have CQed this CL so quickly. Sorry about that, Sylvain. Nah, that's okay, better safe than sorry. Relanding is easy :-) |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
