Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issue 2627973005: Remove obsolete PauseableHttpProtocolHandler class. (Closed)

Created:
3 years, 11 months ago by sdefresne
Modified:
3 years, 11 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete PauseableHttpProtocolHandler class. This class is never referenced apart from declaration/definition and thus can be removed from the codebase. BUG=585700 Review-Url: https://codereview.chromium.org/2627973005 Cr-Commit-Position: refs/heads/master@{#443578} Committed: https://chromium.googlesource.com/chromium/src/+/5688a4a82f90d9c27ab3e39d0dd682ca31f5876a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -83 lines) Patch
M ios/net/crn_http_protocol_handler.h View 1 chunk +0 lines, -9 lines 0 comments Download
M ios/net/crn_http_protocol_handler.mm View 1 chunk +0 lines, -74 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (9 generated)
sdefresne
Please take a look and send to CQ if LGTY.
3 years, 11 months ago (2017-01-12 16:43:27 UTC) #4
Eugene But (OOO till 7-30)
lgtm
3 years, 11 months ago (2017-01-12 16:50:00 UTC) #7
commit-bot: I haz the power
This CL has an open dependency (Issue 2622393004 Patch 1). Please resolve the dependency and ...
3 years, 11 months ago (2017-01-12 16:50:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627973005/1
3 years, 11 months ago (2017-01-13 16:33:45 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5688a4a82f90d9c27ab3e39d0dd682ca31f5876a
3 years, 11 months ago (2017-01-13 16:47:08 UTC) #14
mef
On 2017/01/13 16:47:08, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 11 months ago (2017-01-13 18:07:44 UTC) #15
Eugene But (OOO till 7-30)
3 years, 11 months ago (2017-01-13 18:54:41 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2632643003/ by eugenebut@chromium.org.

The reason for reverting is: Breaks CroNet.

Powered by Google App Engine
This is Rietveld 408576698