Remove obsolete TODO

Remove obsolete TODO

BUG=677160
R=eugenebut@chromium.org,marq@chromium.org

Review-Url: https://codereview.chromium.org/2630733002
Cr-Commit-Position: refs/heads/master@{#443574}
Committed: https://chromium.googlesource.com/chromium/src/+/9685e84627da279a93729b53ac3151b67d7eae46

[lpromero, 2017-01-13 10:54:35]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 10:54:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marq (ping after 24h), 2017-01-13 10:56:33]

lgtm

[commit-bot: I haz the power, 2017-01-13 11:07:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 11:07:27]

Dry run: This issue passed the CQ dry run.

[lpromero, 2017-01-13 11:09:33]

On 2017/01/13 10:56:33, marq wrote:
> lgtm

Thanks!

Eugene, please send to the CQ if lgty.

[Eugene But (OOO till 7-30), 2017-01-13 16:26:47]

When I assigned bug to you, I was wandering if it was better to make a fix in
KeyCommandsProvider. Checking CanGoBack/CanGoForward in BVC and making
navigation no-op would silence certain bugs in the app logic. But if you think
this is fine, then lgtm and thank you for cleanup

[Eugene But (OOO till 7-30), 2017-01-13 16:26:55]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2017-01-13 16:27:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 16:34:39]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484324815947170, "parent_rev":
"8150200aff6ad60b092fd2ddb7eddcb6d0cc13df", "commit_rev":
"9685e84627da279a93729b53ac3151b67d7eae46"}

[commit-bot: I haz the power, 2017-01-13 16:35:10]

Description was changed from

==========
Remove obsolete TODO

BUG=677160
R=eugenebut@chromium.org,marq@chromium.org
==========

to

==========
Remove obsolete TODO

BUG=677160
R=eugenebut@chromium.org,marq@chromium.org

Review-Url: https://codereview.chromium.org/2630733002
Cr-Commit-Position: refs/heads/master@{#443574}
Committed:
https://chromium.googlesource.com/chromium/src/+/9685e84627da279a93729b53ac31...
==========

[commit-bot: I haz the power, 2017-01-13 16:35:11]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9685e84627da279a93729b53ac31...

[lpromero, 2017-01-13 16:45:27]

On 2017/01/13 16:26:47, Eugene But wrote:
> When I assigned bug to you, I was wandering if it was better to make a fix in
> KeyCommandsProvider. Checking CanGoBack/CanGoForward in BVC and making
> navigation no-op would silence certain bugs in the app logic. But if you think
> this is fine, then lgtm and thank you for cleanup

Hmm, we could prevent registering back or forward. If the IDC_BACK command is
sent, we will crash and we will be able to track it down more easily, I see.
Uploading a fix.

[lpromero, 2017-01-13 17:00:00]

On 2017/01/13 16:45:27, lpromero wrote:
> On 2017/01/13 16:26:47, Eugene But wrote:
> > When I assigned bug to you, I was wandering if it was better to make a fix
in
> > KeyCommandsProvider. Checking CanGoBack/CanGoForward in BVC and making
> > navigation no-op would silence certain bugs in the app logic. But if you
think
> > this is fine, then lgtm and thank you for cleanup
> 
> Hmm, we could prevent registering back or forward. If the IDC_BACK command is
> sent, we will crash and we will be able to track it down more easily, I see.
> Uploading a fix.

https://codereview.chromium.org/2631733002