Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issue 2630733002: Remove obsolete TODO (Closed)

Created:
3 years, 11 months ago by lpromero
Modified:
3 years, 11 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M ios/chrome/browser/ui/browser_view_controller.mm View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
lpromero
3 years, 11 months ago (2017-01-13 10:54:34 UTC) #1
marq (ping after 24h)
lgtm
3 years, 11 months ago (2017-01-13 10:56:33 UTC) #4
lpromero
On 2017/01/13 10:56:33, marq wrote: > lgtm Thanks! Eugene, please send to the CQ if ...
3 years, 11 months ago (2017-01-13 11:09:33 UTC) #7
Eugene But (OOO till 7-30)
When I assigned bug to you, I was wandering if it was better to make ...
3 years, 11 months ago (2017-01-13 16:26:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2630733002/1
3 years, 11 months ago (2017-01-13 16:27:31 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/9685e84627da279a93729b53ac3151b67d7eae46
3 years, 11 months ago (2017-01-13 16:35:11 UTC) #13
lpromero
On 2017/01/13 16:26:47, Eugene But wrote: > When I assigned bug to you, I was ...
3 years, 11 months ago (2017-01-13 16:45:27 UTC) #14
lpromero
3 years, 11 months ago (2017-01-13 17:00:00 UTC) #15
Message was sent while issue was closed.
On 2017/01/13 16:45:27, lpromero wrote:
> On 2017/01/13 16:26:47, Eugene But wrote:
> > When I assigned bug to you, I was wandering if it was better to make a fix
in
> > KeyCommandsProvider. Checking CanGoBack/CanGoForward in BVC and making
> > navigation no-op would silence certain bugs in the app logic. But if you
think
> > this is fine, then lgtm and thank you for cleanup
> 
> Hmm, we could prevent registering back or forward. If the IDC_BACK command is
> sent, we will crash and we will be able to track it down more easily, I see.
> Uploading a fix.

https://codereview.chromium.org/2631733002

Powered by Google App Engine
This is Rietveld 408576698