Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Side by Side Diff: ios/chrome/browser/ui/browser_view_controller.mm

Issue 2630733002: Remove obsolete TODO (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/chrome/browser/ui/browser_view_controller.h" 5 #import "ios/chrome/browser/ui/browser_view_controller.h"
6 6
7 #import <AssetsLibrary/AssetsLibrary.h> 7 #import <AssetsLibrary/AssetsLibrary.h>
8 #import <MobileCoreServices/MobileCoreServices.h> 8 #import <MobileCoreServices/MobileCoreServices.h>
9 #import <PassKit/PassKit.h> 9 #import <PassKit/PassKit.h>
10 #import <Photos/Photos.h> 10 #import <Photos/Photos.h>
(...skipping 3896 matching lines...) Expand 10 before | Expand all | Expand 10 after
3907 #pragma mark - Command Handling 3907 #pragma mark - Command Handling
3908 3908
3909 - (IBAction)chromeExecuteCommand:(id)sender { 3909 - (IBAction)chromeExecuteCommand:(id)sender {
3910 NSInteger command = [sender tag]; 3910 NSInteger command = [sender tag];
3911 3911
3912 if (!_model || !_browserState) 3912 if (!_model || !_browserState)
3913 return; 3913 return;
3914 3914
3915 switch (command) { 3915 switch (command) {
3916 case IDC_BACK: 3916 case IDC_BACK:
3917 // TODO(crbug.com/677160): Remove |canGoBack| check.
3918 if ([_model currentTab].canGoBack) { 3917 if ([_model currentTab].canGoBack) {
3919 [[_model currentTab] goBack]; 3918 [[_model currentTab] goBack];
3920 } 3919 }
3921 break; 3920 break;
3922 case IDC_BOOKMARK_PAGE: 3921 case IDC_BOOKMARK_PAGE:
3923 [self initializeBookmarkInteractionController]; 3922 [self initializeBookmarkInteractionController];
3924 [_bookmarkInteractionController 3923 [_bookmarkInteractionController
3925 presentBookmarkForTab:[_model currentTab] 3924 presentBookmarkForTab:[_model currentTab]
3926 currentlyBookmarked:_toolbarModelIOS->IsCurrentTabBookmarkedByUser() 3925 currentlyBookmarked:_toolbarModelIOS->IsCurrentTabBookmarkedByUser()
3927 inView:[_toolbarController bookmarkButtonView] 3926 inView:[_toolbarController bookmarkButtonView]
(...skipping 23 matching lines...) Expand all
3951 [_findBarController updateResultsCount:model]; 3950 [_findBarController updateResultsCount:model];
3952 }]; 3951 }];
3953 break; 3952 break;
3954 case IDC_FIND_CLOSE: 3953 case IDC_FIND_CLOSE:
3955 [self closeFindInPage]; 3954 [self closeFindInPage];
3956 break; 3955 break;
3957 case IDC_FIND_UPDATE: 3956 case IDC_FIND_UPDATE:
3958 [self searchFindInPage]; 3957 [self searchFindInPage];
3959 break; 3958 break;
3960 case IDC_FORWARD: 3959 case IDC_FORWARD:
3961 // TODO(crbug.com/677160): Remove |canGoForward| check.
3962 if ([_model currentTab].canGoForward) { 3960 if ([_model currentTab].canGoForward) {
3963 [[_model currentTab] goForward]; 3961 [[_model currentTab] goForward];
3964 } 3962 }
3965 break; 3963 break;
3966 case IDC_FULLSCREEN: 3964 case IDC_FULLSCREEN:
3967 NOTIMPLEMENTED(); 3965 NOTIMPLEMENTED();
3968 break; 3966 break;
3969 case IDC_HELP_PAGE_VIA_MENU: 3967 case IDC_HELP_PAGE_VIA_MENU:
3970 [self showHelpPage]; 3968 [self showHelpPage];
3971 break; 3969 break;
(...skipping 1168 matching lines...) Expand 10 before | Expand all | Expand 10 after
5140 5138
5141 - (UIView*)voiceSearchButton { 5139 - (UIView*)voiceSearchButton {
5142 return _voiceSearchButton; 5140 return _voiceSearchButton;
5143 } 5141 }
5144 5142
5145 - (id<LogoAnimationControllerOwner>)logoAnimationControllerOwner { 5143 - (id<LogoAnimationControllerOwner>)logoAnimationControllerOwner {
5146 return [self currentLogoAnimationControllerOwner]; 5144 return [self currentLogoAnimationControllerOwner];
5147 } 5145 }
5148 5146
5149 @end 5147 @end
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698