Avoid sending IDC_BACK/FORWARD when back/forward is not possible

Avoid sending IDC_BACK/FORWARD when back/forward is not possible

This moves down logic to the KeyCommandsProvider, that registers key
commands handlers that check if navigation is possible before sneding
IDC_BACK/FORWARD Chrome commands.

BUG=677160
R=eugenebug@chromium.org,marq@chromium.org

Review-Url: https://codereview.chromium.org/2631733002
Cr-Commit-Position: refs/heads/master@{#443603}
Committed: https://chromium.googlesource.com/chromium/src/+/47ea8860bd01ee9a9498a893ff9eeec2618fa75e

[lpromero, 2017-01-13 16:59:46]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 17:00:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 17:02:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 17:02:46]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Eugene But (OOO till 7-30), 2017-01-13 17:10:55]

eugenebut@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-01-13 17:10:55]

lgtm

[marq (ping after 24h), 2017-01-13 17:28:29]

lgtm

[lpromero, 2017-01-13 17:36:00]

The CQ bit was checked by lpromero@chromium.org

[commit-bot: I haz the power, 2017-01-13 17:36:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpromero, 2017-01-13 17:39:18]

The CQ bit was checked by lpromero@chromium.org

[lpromero, 2017-01-13 17:39:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org, marq@chromium.org
Link to the patchset: https://codereview.chromium.org/2631733002/#ps20001
(title: "Rebased")

[commit-bot: I haz the power, 2017-01-13 17:39:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 17:51:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484329158287970,
"parent_rev": "c28b58acd5f0866b81313806821d7e06b630a98c", "commit_rev":
"47ea8860bd01ee9a9498a893ff9eeec2618fa75e"}

[commit-bot: I haz the power, 2017-01-13 17:51:42]

Description was changed from

==========
Avoid sending IDC_BACK/FORWARD when back/forward is not possible

This moves down logic to the KeyCommandsProvider, that registers key
commands handlers that check if navigation is possible before sneding
IDC_BACK/FORWARD Chrome commands.

BUG=677160
R=eugenebug@chromium.org,marq@chromium.org
==========

to

==========
Avoid sending IDC_BACK/FORWARD when back/forward is not possible

This moves down logic to the KeyCommandsProvider, that registers key
commands handlers that check if navigation is possible before sneding
IDC_BACK/FORWARD Chrome commands.

BUG=677160
R=eugenebug@chromium.org,marq@chromium.org

Review-Url: https://codereview.chromium.org/2631733002
Cr-Commit-Position: refs/heads/master@{#443603}
Committed:
https://chromium.googlesource.com/chromium/src/+/47ea8860bd01ee9a9498a893ff9e...
==========

[commit-bot: I haz the power, 2017-01-13 17:51:44]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/47ea8860bd01ee9a9498a893ff9e...