Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2629823002: Add CHECKs to make sure ThreadableLoader has not been created multiple times (Closed)

Created:
3 years, 11 months ago by yhirano
Modified:
3 years, 11 months ago
CC:
chromium-reviews, tzik, nhiroki, shimazu+worker_chromium.org, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, kinuko+fileapi, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add CHECKs to make sure ThreadableLoader has not been created multiple times A ThreadableLoader must be completed before it's destructed. We need to forbid to create ThreadableLoader multiple times in some classes to ensure that. This CL adds CHECKs to make sure that. BUG=667254 Review-Url: https://codereview.chromium.org/2629823002 Cr-Commit-Position: refs/heads/master@{#443506} Committed: https://chromium.googlesource.com/chromium/src/+/9cdca0764fe0ab606d904f8e2bd6eb5117773a97

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerScriptLoader.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/eventsource/EventSource.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchManager.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebAssociatedURLLoaderImpl.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
yhirano
3 years, 11 months ago (2017-01-13 04:13:19 UTC) #6
tyoshino (SeeGerritForStatus)
lgtm
3 years, 11 months ago (2017-01-13 06:04:42 UTC) #9
yhirano
+haraken@ for owner review.
3 years, 11 months ago (2017-01-13 06:09:20 UTC) #12
haraken
LGTM
3 years, 11 months ago (2017-01-13 06:10:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629823002/20001
3 years, 11 months ago (2017-01-13 06:12:37 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 06:18:13 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9cdca0764fe0ab606d904f8e2bd6...

Powered by Google App Engine
This is Rietveld 408576698