third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp - Issue 2629823002: Add CHECKs to make sure ThreadableLoader has not been created multiple times

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp

Issue 2629823002: Add CHECKs to make sure ThreadableLoader has not been created multiple times (Closed)

Patch Set: fix Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/fetch/FetchManager.cpp ('k') | third_party/WebKit/Source/web/WebAssociatedURLLoaderImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp b/third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp

index 00ba58c1a6114778667138e89eb1e88e5d3e96e8..9cec819fd5d2d19d56653fd0a876fde4b4ac99f3 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp

+++ b/third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp

@@ -120,6 +120,8 @@ void NotificationImageLoader::start(

resourceRequest.setPriority(ResourceLoadPriorityMedium);

resourceRequest.setRequestorOrigin(executionContext->getSecurityOrigin());

+ // TODO(yhirano): Remove this CHECK once https://crbug.com/667254 is fixed.

+ CHECK(!m_threadableLoader);

m_threadableLoader = ThreadableLoader::create(

*executionContext, this, threadableLoaderOptions, resourceLoaderOptions);

m_threadableLoader->start(resourceRequest);