third_party/WebKit/Source/modules/eventsource/EventSource.cpp - Issue 2629823002: Add CHECKs to make sure ThreadableLoader has not been created multiple times

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/eventsource/EventSource.cpp

Issue 2629823002: Add CHECKs to make sure ThreadableLoader has not been created multiple times (Closed)

Patch Set: fix Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/eventsource/EventSource.cpp

diff --git a/third_party/WebKit/Source/modules/eventsource/EventSource.cpp b/third_party/WebKit/Source/modules/eventsource/EventSource.cpp

index 07900d767145ff7e93dd4657643f8c67fd930f05..33034f98f2da0a57dc3b87a48a07de4910cdcad3 100644

--- a/third_party/WebKit/Source/modules/eventsource/EventSource.cpp

+++ b/third_party/WebKit/Source/modules/eventsource/EventSource.cpp

@@ -173,6 +173,8 @@ void EventSource::connect() {

resourceLoaderOptions.securityOrigin = origin;

InspectorInstrumentation::willSendEventSourceRequest(&executionContext, this);

+ // TODO(yhirano): Remove this CHECK once https://crbug.com/667254 is fixed.

+ CHECK(!m_loader);

// InspectorInstrumentation::documentThreadableLoaderStartedLoadingForClient

// will be called synchronously.

m_loader = ThreadableLoader::create(executionContext, this, options,